Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chart: make webhook optional #210

Merged
merged 1 commit into from
Nov 28, 2024
Merged

Conversation

haorenfsa
Copy link
Collaborator

Fix #132

@sre-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haorenfsa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Nov 19, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 80.92%. Comparing base (a42492e) to head (b17fc14).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pkg/util/util.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##           main     #210       +/-   ##
=========================================
+ Coverage      0   80.92%   +80.92%     
=========================================
  Files         0       56       +56     
  Lines         0     6222     +6222     
=========================================
+ Hits          0     5035     +5035     
- Misses        0     1000     +1000     
- Partials      0      187      +187     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@haorenfsa haorenfsa force-pushed the cert-manager branch 4 times, most recently from 9ec5672 to 6981af5 Compare November 19, 2024 13:51
@haorenfsa haorenfsa changed the title chart: make cert-manager dependency in chart, support disable webhook chart: make webhook optional Nov 19, 2024
@haorenfsa haorenfsa force-pushed the cert-manager branch 6 times, most recently from c406d8b to 4c6a75c Compare November 21, 2024 10:40
@haorenfsa haorenfsa force-pushed the cert-manager branch 3 times, most recently from f02caa9 to 918aeb3 Compare November 28, 2024 07:25
@haorenfsa haorenfsa added the lgtm looks good to merge label Nov 28, 2024
@haorenfsa haorenfsa enabled auto-merge (rebase) November 28, 2024 07:52
@haorenfsa haorenfsa disabled auto-merge November 28, 2024 07:52
@haorenfsa haorenfsa merged commit ea9cd59 into zilliztech:main Nov 28, 2024
16 checks passed
@haorenfsa haorenfsa deleted the cert-manager branch November 29, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FAQ doc for webhook cert related issue
2 participants