Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rolling querynode 1 by 1 using 2 deployments #74

Merged
merged 28 commits into from
Feb 5, 2024

Conversation

haorenfsa
Copy link
Collaborator

No description provided.

Signed-off-by: shaoyue.chen <[email protected]>
Signed-off-by: shaoyue.chen <[email protected]>
Signed-off-by: shaoyue.chen <[email protected]>
Signed-off-by: shaoyue.chen <[email protected]>
Signed-off-by: shaoyue.chen <[email protected]>
Signed-off-by: shaoyue.chen <[email protected]>
Signed-off-by: shaoyue.chen <[email protected]>
Signed-off-by: shaoyue.chen <[email protected]>
Signed-off-by: shaoyue.chen <[email protected]>
Signed-off-by: shaoyue.chen <[email protected]>
Signed-off-by: shaoyue.chen <[email protected]>
Signed-off-by: shaoyue.chen <[email protected]>
Signed-off-by: shaoyue.chen <[email protected]>
Signed-off-by: shaoyue.chen <[email protected]>
Signed-off-by: shaoyue.chen <[email protected]>
Signed-off-by: shaoyue.chen <[email protected]>
Signed-off-by: shaoyue.chen <[email protected]>
@sre-ci-robot sre-ci-robot requested a review from zwd1208 February 4, 2024 07:40
@sre-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haorenfsa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Feb 4, 2024

Codecov Report

Attention: 165 lines in your changes are missing coverage. Please review.

Comparison is base (5af6827) 80.23% compared to head (0ba0b54) 80.80%.

❗ Current head 0ba0b54 differs from pull request most recent head 4c1b8eb. Consider uploading reports for the commit 4c1b8eb to get more accurate results

Files Patch % Lines
pkg/controllers/status_cluster.go 38.09% 24 Missing and 2 partials ⚠️
pkg/controllers/component_condition.go 0.00% 22 Missing ⚠️
pkg/controllers/query_node.go 91.45% 12 Missing and 5 partials ⚠️
pkg/controllers/error_detail.go 0.00% 13 Missing ⚠️
pkg/controllers/query_node_util.go 95.23% 9 Missing and 4 partials ⚠️
pkg/controllers/conditions.go 29.41% 9 Missing and 3 partials ⚠️
pkg/controllers/deployments.go 36.84% 8 Missing and 4 partials ⚠️
pkg/controllers/rollout_util.go 91.66% 7 Missing and 4 partials ⚠️
pkg/controllers/setup.go 0.00% 8 Missing ⚠️
apis/milvus.io/v1beta1/label_annotations.go 85.36% 4 Missing and 2 partials ⚠️
... and 7 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #74      +/-   ##
==========================================
+ Coverage   80.23%   80.80%   +0.56%     
==========================================
  Files          47       52       +5     
  Lines        4918     5839     +921     
==========================================
+ Hits         3946     4718     +772     
- Misses        818      940     +122     
- Partials      154      181      +27     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: shaoyue.chen <[email protected]>
Signed-off-by: shaoyue.chen <[email protected]>
Signed-off-by: shaoyue.chen <[email protected]>
Signed-off-by: shaoyue.chen <[email protected]>
Signed-off-by: shaoyue.chen <[email protected]>
Signed-off-by: shaoyue.chen <[email protected]>
@haorenfsa haorenfsa added the lgtm looks good to merge label Feb 5, 2024
@haorenfsa haorenfsa merged commit bc7b38c into zilliztech:main Feb 5, 2024
12 of 13 checks passed
@haorenfsa haorenfsa deleted the rolling branch February 5, 2024 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants