OAuth2: Add support for refresh tokens on Github #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Github apps have optional expiration of access tokens, which leads to using refresh token to obtain new access token (and new refresh token). This patch adds support for refresh tokens on Github, which was previously missing. Although the Github documentation specifies that 'client_secret' is a required parameter for refreshing token, it is not required in this case for unknown reason (perhaps device flow?). Additionally after this change, new refresh token will be used preferentially, if present in refresh token response.
jdegoes
approved these changes
Jul 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Github apps have optional expiration of access tokens, which leads to using refresh token to obtain new access token (and new refresh token). This patch adds support for refresh tokens on Github, which was previously missing.
Although the Github documentation specifies that
client_secretis a required parameter for refreshing token, it is not required in this case for unknown reason (perhaps device flow?).Additionally after this change, new refresh token will be used preferentially, if present in refresh token response.