chore/build/refactor-to-projectmatrix-and-upgrade-all-dependencies #1466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThijsBroersen
force-pushed
the
chore/build/refactor-to-projectmatrix-and-bump-all
branch
2 times, most recently
from
f6b944c
to
b5c4abc
Compare
|
I reverted the zio-sbt-website version. As the new version added a |
ThijsBroersen
commented
Oct 7, 2024
examples/src/main/scala/zio/config/examples/autoderivation/AutoDerivationPureConfig.scala
Outdated
Show resolved
Hide resolved
ThijsBroersen
commented
Oct 7, 2024
| @@ -42,7 +42,7 @@ object AutomaticConfig extends App { | |||
| "aws.credentials.Token.value" -> "token", | |||
| "port" -> "10", | |||
| "default" -> "12", | |||
| "dburl" -> "some url", | |||
| "dburl.value" -> "some url", | |||
There was a problem hiding this comment.
There is some inconsistency on the usage of value-classes. Sometimes AnyVal is extended, sometimes not. In some tests it expects the path to have the nested path, but in this code it did not.
I think also some apps were not working in in the main branch. This change for now makes it work.
ThijsBroersen
force-pushed
the
chore/build/refactor-to-projectmatrix-and-bump-all
branch
from
e1a3919
to
9b11812
Compare
ThijsBroersen
force-pushed
the
chore/build/refactor-to-projectmatrix-and-bump-all
branch
from
9b11812
to
dc0f710
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR to update about all...
Build has been migrated to sbt-projectmatrix because the existing build had quite some issues and did target all platforms and versions correctly.
I also noticed some gaps. Like annotations not implemented for Scala 3.
I updated also the JDK version to 17 setting the jvm release target to 11 (same behaviour as the core zio project).Perhaps I am mistaken. Multiple JDK versions are used but for releasing artifacts JDK 11 targeting 11, correct? Is there any logic here? To my knowledge building with any recent JDK, targetting an earlier JDK version with the '-release' flag should be sufficient right?