Multi-value segments for PathCodecs #2959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The full RFC 6570 - URI Template has no place in zio-http, since it is very focused on query param extraction and zio-http has no query params defined in the path. @kyri-petrou and I went with multi-value segments as the way to implement what the issue creator seemed to care most about. |
987Nabil
force-pushed
the
substring-path-decoders
branch
3 times, most recently
from
c63dea4
to
cff0d9a
Compare
987Nabil
force-pushed
the
substring-path-decoders
branch
from
cff0d9a
to
b201934
Compare
987Nabil
changed the title
jdegoes
approved these changes
Jul 15, 2024
|
Nicely done! Thanks for the attention to performance in this critical section of the code. 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2679
/claim #2679
/split @kyri-petrou