Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide Authentication information via EndpointExecutor (#3019) #3026

Merged
merged 1 commit into from
Aug 24, 2024

Conversation

987Nabil
Copy link
Contributor

fixes #3019
/claim #3019

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 78.94737% with 4 lines in your changes missing coverage. Please review.

Project coverage is 65.63%. Comparing base (e2f2cb5) to head (f9f61e3).

Files Patch % Lines
...ed/src/main/scala/zio/http/endpoint/Endpoint.scala 33.33% 2 Missing ⚠️
...ain/scala/zio/http/endpoint/EndpointExecutor.scala 66.66% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3026      +/-   ##
==========================================
- Coverage   65.65%   65.63%   -0.02%     
==========================================
  Files         155      155              
  Lines       10134    10133       -1     
  Branches     1899     1904       +5     
==========================================
- Hits         6653     6651       -2     
- Misses       3481     3482       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@jdegoes jdegoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Such a huge cleanup and big improvement to usability! 🎉

@jdegoes jdegoes merged commit a8b432d into zio:main Aug 24, 2024
64 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle auth for endpoint without explicit handover
3 participants