Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Date Operations #106

Closed
wants to merge 5 commits into from
Closed

Date Operations #106

wants to merge 5 commits into from

Conversation

rleibman
Copy link

@rleibman rleibman commented May 19, 2022

Fixes #108

Problem

Explain here the context, and why you're making that change.
What is the problem you're trying to solve?

Solution

Describe the modifications you've done.

Notes

Additional notes.

Checklist

  • Unit test all changes
  • Update README.md if applicable
  • Add [WIP] to the pull request title if it's work in progress
  • Squash commits that aren't meaningful changes

@getquill/maintainers

@CLAassistant
Copy link

CLAassistant commented May 19, 2022

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ guizmaii
❌ Roberto Leibman


Roberto Leibman seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@guizmaii
Copy link
Member

@rleibman Can you rebase your PR, please?

@rleibman
Copy link
Author

Boom there it is.

@guizmaii
Copy link
Member

Thanks! 😄
Compilation fails tho 😅

@rleibman
Copy link
Author

I would love to fix it, but it doesn't build locally:

[info] loading settings for project quill from build.sbt ...
[info] resolving key references (15659 settings) ...
java.lang.RuntimeException: Some keys were defined with the same name but different types: 'gitReader' (com.github.sbt.git.ReadableGit, com.typesafe.sbt.git.ReadableGit), 'gitRunner' (sbt.Task[com.typesafe.sbt.git.GitRunner], sbt.Task[com.github.sbt.git.GitRunner])

@guizmaii
Copy link
Member

guizmaii commented Oct 1, 2023

@rleibman Did you configure any "global sbt plugins"?

@rleibman
Copy link
Author

rleibman commented Oct 1, 2023

Yeah, there's an incompatibility somewhere with sbt-prompt!

@rleibman
Copy link
Author

rleibman commented Oct 1, 2023

ok, I fixed some of the compiler errors in Dsl.scala, but in Parser.scala, there's some errors I'm not sure how to fix, and if they are very deep and require a lot of knowledge of internals of quill I'm not sure how much effort I want to put into them:

/Users/rleibman/projects/other/zio-protoquill/quill-sql/src/main/scala/io/getquill/parser/Parser.scala:893:64
Found:    (a : ExtrasParser.this.x$2.reflect.Term)
Required: quoted.Expr[?]

@rleibman rleibman closed this by deleting the head repository Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Frequently used Date Operations (protoquill)
3 participants