Skip to content

Commit

Permalink
rename redis-it's BaseSpec to IntegrationSpec to avoid confusion with…
Browse files Browse the repository at this point in the history
… test's BaseSpec (#980)
  • Loading branch information
maizy authored Jul 28, 2024
1 parent 063a4f6 commit 637377d
Show file tree
Hide file tree
Showing 16 changed files with 28 additions and 28 deletions.
10 changes: 5 additions & 5 deletions modules/redis-it/src/test/scala/zio/redis/ApiSpec.scala
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,9 @@ object ApiSpec
suite("Redis commands")(ClusterSuite, SingleNodeSuite)
.provideShared(
compose(
service(BaseSpec.SingleNode0, ".*Ready to accept connections.*"),
service(BaseSpec.SingleNode1, ".*Ready to accept connections.*"),
service(BaseSpec.MasterNode, ".*Cluster correctly created.*")
service(IntegrationSpec.SingleNode0, ".*Ready to accept connections.*"),
service(IntegrationSpec.SingleNode1, ".*Ready to accept connections.*"),
service(IntegrationSpec.MasterNode, ".*Cluster correctly created.*")
)
) @@ sequential @@ withLiveEnvironment

Expand All @@ -48,7 +48,7 @@ object ApiSpec
Redis.cluster,
masterNodeConfig,
ZLayer.succeed(ProtobufCodecSupplier)
).filterNotTags(_.contains(BaseSpec.ClusterExecutorUnsupported))
).filterNotTags(_.contains(IntegrationSpec.ClusterExecutorUnsupported))
.getOrElse(Spec.empty) @@ flaky @@ ifEnvNotSet("CI")

private final val SingleNodeSuite =
Expand All @@ -68,7 +68,7 @@ object ApiSpec
).provideSomeShared[DockerComposeContainer](
Redis.singleNode,
RedisSubscription.singleNode,
singleNodeConfig(BaseSpec.SingleNode0),
singleNodeConfig(IntegrationSpec.SingleNode0),
ZLayer.succeed(ProtobufCodecSupplier)
)
}
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import com.dimafeng.testcontainers.DockerComposeContainer
import zio._
import zio.test._

trait ClusterSpec extends BaseSpec {
trait ClusterSpec extends IntegrationSpec {
def clusterSpec: Spec[DockerComposeContainer & Redis, RedisError] =
suite("cluster")(
suite("slots")(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import zio.test.Assertion._
import zio.test.TestAspect._
import zio.test._

trait ConnectionSpec extends BaseSpec {
trait ConnectionSpec extends IntegrationSpec {
def connectionSuite: Spec[Redis, RedisError] =
suite("connection")(
suite("authenticating")(
Expand Down
2 changes: 1 addition & 1 deletion modules/redis-it/src/test/scala/zio/redis/GeoSpec.scala
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import zio.test.Assertion._
import zio.test._
import zio.{Chunk, ZIO}

trait GeoSpec extends BaseSpec {
trait GeoSpec extends IntegrationSpec {
def geoSuite: Spec[Redis, RedisError] =
suite("geo")(
test("geoAdd followed by geoPos") {
Expand Down
2 changes: 1 addition & 1 deletion modules/redis-it/src/test/scala/zio/redis/HashSpec.scala
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import zio.test.Assertion._
import zio.test._
import zio.{Chunk, ZIO}

trait HashSpec extends BaseSpec {
trait HashSpec extends IntegrationSpec {
def hashSuite: Spec[Redis, RedisError] =
suite("hash")(
suite("hSet, hGet, hGetAll and hDel")(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import zio.ZIO
import zio.test.Assertion._
import zio.test._

trait HyperLogLogSpec extends BaseSpec {
trait HyperLogLogSpec extends IntegrationSpec {
def hyperLogLogSuite: Spec[Redis, RedisError] =
suite("hyperloglog")(
suite("add elements")(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ import zio.{ULayer, _}
import java.io.File
import java.util.UUID

trait BaseSpec extends ZIOSpecDefault {
trait IntegrationSpec extends ZIOSpecDefault {
implicit def summonCodec[A: Schema]: BinaryCodec[A] = ProtobufCodec.protobufCodec

override def aspects: Chunk[TestAspectAtLeastR[Live]] =
Expand All @@ -30,7 +30,7 @@ trait BaseSpec extends ZIOSpecDefault {
ZLayer {
for {
docker <- ZIO.service[DockerComposeContainer]
hostAndPort <- docker.getHostAndPort(BaseSpec.MasterNode)(6379)
hostAndPort <- docker.getHostAndPort(IntegrationSpec.MasterNode)(6379)
uri = RedisUri(s"${hostAndPort._1}:${hostAndPort._2}")
} yield RedisClusterConfig(Chunk(uri))
}
Expand All @@ -53,7 +53,7 @@ trait BaseSpec extends ZIOSpecDefault {
* - fork/join approach for commands that operate on keys with different slots
*/
final val clusterExecutorUnsupported: TestAspectPoly =
tag(BaseSpec.ClusterExecutorUnsupported)
tag(IntegrationSpec.ClusterExecutorUnsupported)

final val genStringRedisTypeOption: Gen[Any, Option[RedisType]] =
Gen.option(Gen.constSample(Sample.noShrink(RedisType.String)))
Expand All @@ -68,7 +68,7 @@ trait BaseSpec extends ZIOSpecDefault {
ZIO.succeed(UUID.randomUUID().toString)
}

object BaseSpec {
object IntegrationSpec {
final val ClusterExecutorUnsupported = "cluster executor not supported"
final val MasterNode = "cluster-node-5"
final val SingleNode0 = "single-node-0"
Expand Down
10 changes: 5 additions & 5 deletions modules/redis-it/src/test/scala/zio/redis/KeysSpec.scala
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import zio.test.Assertion.{exists => _, _}
import zio.test.TestAspect.{restore => _, _}
import zio.test._

trait KeysSpec extends BaseSpec {
trait KeysSpec extends IntegrationSpec {
def keysSuite: Spec[DockerComposeContainer & Redis, RedisError] = {
suite("keys")(
test("set followed by get") {
Expand Down Expand Up @@ -177,7 +177,7 @@ trait KeysSpec extends BaseSpec {
_ <- redis.set(key, value)
response <- redis
.migrate(
BaseSpec.SingleNode1,
IntegrationSpec.SingleNode1,
6379,
key,
0L,
Expand All @@ -199,7 +199,7 @@ trait KeysSpec extends BaseSpec {
redis <- ZIO.service[Redis]
_ <- redis.set(key, value)
response <- redis.migrate(
BaseSpec.SingleNode1,
IntegrationSpec.SingleNode1,
6379L,
key,
0L,
Expand All @@ -225,7 +225,7 @@ trait KeysSpec extends BaseSpec {
.provideLayer(secondExecutor) // also add to second Redis
response <- redis
.migrate(
BaseSpec.SingleNode1,
IntegrationSpec.SingleNode1,
6379,
key,
0L,
Expand Down Expand Up @@ -515,7 +515,7 @@ trait KeysSpec extends BaseSpec {
private val secondExecutor =
ZLayer
.makeSome[DockerComposeContainer, Redis](
singleNodeConfig(BaseSpec.SingleNode1),
singleNodeConfig(IntegrationSpec.SingleNode1),
ZLayer.succeed[CodecSupplier](ProtobufCodecSupplier),
Redis.singleNode
)
Expand Down
2 changes: 1 addition & 1 deletion modules/redis-it/src/test/scala/zio/redis/ListSpec.scala
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import zio.test._

import java.util.concurrent.TimeUnit

trait ListSpec extends BaseSpec {
trait ListSpec extends IntegrationSpec {
def listSuite: Spec[Redis, Any] =
suite("lists")(
suite("pop")(
Expand Down
2 changes: 1 addition & 1 deletion modules/redis-it/src/test/scala/zio/redis/PubSubSpec.scala
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import zio.{Promise, ZIO}

import scala.util.Random

trait PubSubSpec extends BaseSpec {
trait PubSubSpec extends IntegrationSpec {
def pubSubSuite: Spec[Redis with RedisSubscription, RedisError] =
suite("pubSubs")(
suite("subscribe")(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import zio.test._

import scala.util.Random

trait ScriptingSpec extends BaseSpec {
trait ScriptingSpec extends IntegrationSpec {
def scriptingSpec: Spec[Redis, RedisError] =
suite("scripting")(
suite("eval")(
Expand Down
2 changes: 1 addition & 1 deletion modules/redis-it/src/test/scala/zio/redis/SetsSpec.scala
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import zio.stream.ZStream
import zio.test.Assertion._
import zio.test._

trait SetsSpec extends BaseSpec {
trait SetsSpec extends IntegrationSpec {
def setsSuite: Spec[Redis, RedisError] =
suite("sets")(
suite("sAdd")(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import zio.stream.ZStream
import zio.test.Assertion._
import zio.test._

trait SortedSetsSpec extends BaseSpec {
trait SortedSetsSpec extends IntegrationSpec {
def sortedSetsSuite: Spec[Redis, RedisError] =
suite("sorted sets")(
suite("bzPopMax")(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import zio.test.Assertion._
import zio.test.TestAspect.{flaky, ignore}
import zio.test._

trait StreamsSpec extends BaseSpec {
trait StreamsSpec extends IntegrationSpec {
def streamsSuite: Spec[Redis, RedisError] =
suite("streams")(
suite("xAck")(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import zio.test.Assertion.{exists => _, _}
import zio.test.TestAspect.{flaky, ignore}
import zio.test._

trait StringsSpec extends BaseSpec {
trait StringsSpec extends IntegrationSpec {
def stringsSuite: Spec[Redis, RedisError] =
suite("strings")(
suite("append")(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import zio.redis.options.Cluster.{Slot, SlotsAmount}
import zio.test.TestAspect.{flaky, ifEnvNotSet}
import zio.test._

object ClusterExecutorSpec extends BaseSpec {
object ClusterExecutorSpec extends IntegrationSpec {
def spec: Spec[TestEnvironment, Any] =
suite("Cluster executor")(
test("check cluster responsiveness when ASK redirect happens") {
Expand Down Expand Up @@ -62,7 +62,7 @@ object ClusterExecutorSpec extends BaseSpec {
}
).provideShared(
Redis.cluster,
compose(service(BaseSpec.MasterNode, ".*Cluster correctly created.*")),
compose(service(IntegrationSpec.MasterNode, ".*Cluster correctly created.*")),
masterNodeConfig,
ZLayer.succeed(ProtobufCodecSupplier)
) @@ flaky @@ ifEnvNotSet("CI")
Expand Down

0 comments on commit 637377d

Please sign in to comment.