Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: s3 dynamic keys #5

Merged
merged 3 commits into from
Oct 11, 2024
Merged

feat: s3 dynamic keys #5

merged 3 commits into from
Oct 11, 2024

Conversation

zirkelc
Copy link
Owner

@zirkelc zirkelc commented Oct 11, 2024

Allow to build dynamic keys from payload:

const s3Store = new S3Store<Payload>({
  config: { region },
  bucket,
  key: ({ payload }) => payload.id,
});

Copy link

changeset-bot bot commented Oct 11, 2024

🦋 Changeset detected

Latest commit: dde38cd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
middy-store-s3 Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Oct 11, 2024

Coverage Report

Status Category Percentage Covered / Total
🔴 Lines 55.39% (🎯 80%) 590 / 1065
🔴 Statements 55.39% (🎯 80%) 590 / 1065
🔴 Functions 78.87% (🎯 80%) 56 / 71
🟢 Branches 80.95% (🎯 80%) 204 / 252
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
vitest.root.ts 0% 0% 0% 0% 1-2, 8-9, 11-13, 16-19, 22-23, 25-35
examples/s3-store/index.ts 0% 0% 0% 0% 1, 14-15, 17-18, 20, 30-31, 37-46, 48, 50, 52, 54-55, 57-64, 66, 68-70, 72-78, 80-83, 89, 95, 101
packages/store-s3/src/store.ts 97.05% 86.66% 100% 97.05% 189, 200-202
packages/store-s3/src/utils.ts 94.73% 92.85% 100% 94.73% 57-58
Generated in workflow #57 for commit dde38cd by the Vitest Coverage Report Action

@zirkelc zirkelc merged commit edf0b5a into main Oct 11, 2024
2 checks passed
@zirkelc zirkelc deleted the s3-key branch October 11, 2024 07:23
@github-actions github-actions bot mentioned this pull request Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant