Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(example): check access token expiration #702

Merged
merged 2 commits into from
Feb 13, 2025

Conversation

mqf20
Copy link
Contributor

@mqf20 mqf20 commented Jan 27, 2025

Description

This PR improves the example.

It checks that the access token is not expired before setting user info.

Definition of Ready

  • I am happy with the code
  • Short description of the feature/issue is added in the pr description
  • PR is linked to the corresponding user story
  • Acceptance criteria are met
  • All open todos and follow ups are defined in a new ticket and justified
  • Deviations from the acceptance criteria and design are agreed with the PO and documented.
  • No debug or dead code
  • My code has no repetitions
  • Critical parts are tested automatically
  • Where possible E2E tests are implemented
  • Documentation/examples are up-to-date
  • All non-functional requirements are met
  • Functionality of the acceptance criteria is checked manually on the dev system.

@muhlemmer muhlemmer self-requested a review January 29, 2025 10:38
@muhlemmer muhlemmer added the waiting For some reason, this issue will have to wait. This can be a feedback that is being waited for, a de label Jan 30, 2025
@muhlemmer
Copy link
Collaborator

Waiting for #698 (comment) to be applied.

@muhlemmer muhlemmer changed the title check access token expiration docs(example): check access token expiration Feb 13, 2025
@muhlemmer muhlemmer enabled auto-merge (squash) February 13, 2025 11:32
@muhlemmer muhlemmer disabled auto-merge February 13, 2025 11:32
@muhlemmer muhlemmer enabled auto-merge (squash) February 13, 2025 11:32
@muhlemmer muhlemmer removed the waiting For some reason, this issue will have to wait. This can be a feedback that is being waited for, a de label Feb 13, 2025
@muhlemmer muhlemmer merged commit c03a8c5 into zitadel:main Feb 13, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants