Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Promote Qa to Prod - (User Invitations, integration tests) #245

Merged
merged 101 commits into from
Nov 11, 2024
Merged

Promote Qa to Prod - (User Invitations, integration tests) #245

merged 101 commits into from
Nov 11, 2024

Conversation

peintnermax
Copy link
Member

Includes #233

Definition of Ready

  • I am happy with the code
  • Short description of the feature/issue is added in the pr description
  • PR is linked to the corresponding user story
  • Acceptance criteria are met
  • All open todos and follow ups are defined in a new ticket and justified
  • Deviations from the acceptance criteria and design are agreed with the PO and documented.
  • Vitest unit tests ensure that components produce expected outputs on different inputs.
  • Cypress integration tests ensure that login app pages work as expected. The ZITADEL API is mocked.
  • No debug or dead code
  • My code has no repetitions

eliobischof and others added 30 commits October 16, 2024 09:53
@eliobischof
use postgres
4772861
@eliobischof
setup playwright
73a385c
@eliobischof
pipeline
8c6d957
@eliobischof
build and test
fe289e3
@eliobischof
test on pr
ac7cbe5
@eliobischof
rename pipeline workflows
5be0ed4
@eliobischof
generate
2fa16d5
@eliobischof
timeout
653b499
@eliobischof
submit username and password
f1b756b
@eliobischof
concurrent setup
c5620e6
@eliobischof
fail earlier
576cdcc
@eliobischof
kill -0
ca0e551
@eliobischof
build with env
be84e94
@eliobischof
compose to background
17e516a
@eliobischof
wait individually
3ff49c3
@eliobischof
await setup
c413805
@eliobischof
default uid
b058b75
@eliobischof
use current user
77fb366
@eliobischof
use root
76430e1
@eliobischof
runneradmin
5969b14
@eliobischof
root
4cb1795
@eliobischof
simplify setup
cb8f071
@peintnermax
Merge branch 'main' into acceptance-test-suite
f7796e3
@eliobischof
develop against local zitadel
1134b9c
@peintnermax
fix autocomplete for otp code
4606077
@peintnermax
invite and invite success pages
94e2d31
@peintnermax
urlTemplate
18a1262
@eliobischof
Merge branch 'acceptance-test-suite' of github.com:zitadel/typescript…
6883497 
… into acceptance-test-suite
@eliobischof
run acceptance
1ca16f9
@eliobischof
remove gh workflow
7b43cac
@peintnermax peintnermax marked this pull request as ready for review October 29, 2024 09:50
eliobischof
eliobischof requested changes Nov 11, 2024
View reviewed changes
apps/login/src/app/global-error.tsx Outdated Show resolved Hide resolved
apps/login/src/components/change-password-form.tsx Show resolved Hide resolved
apps/login/src/components/invite-form.tsx Outdated Show resolved Hide resolved
apps/login/src/components/invite-form.tsx Show resolved Hide resolved
apps/login/src/components/register-form-without-password.tsx Outdated Show resolved Hide resolved
apps/login/src/components/register-form-without-password.tsx Outdated Show resolved Hide resolved
apps/login/src/components/verify-form.tsx Outdated Show resolved Hide resolved
apps/login/src/lib/cookies.ts Show resolved Hide resolved
apps/login/src/lib/server/loginname.ts Outdated Show resolved Hide resolved
apps/login/src/lib/zitadel.ts Show resolved Hide resolved
@peintnermax peintnermax merged commit 0e03a57 into main Nov 11, 2024
7 checks passed
@peintnermax peintnermax deleted the qa branch November 11, 2024 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eliobischof eliobischof Awaiting requested review from eliobischof

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@peintnermax @eliobischof