Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: migrate loginname page to buf #75

Closed
wants to merge 1 commit into from
Closed

feat: migrate loginname page to buf #75

wants to merge 1 commit into from

Conversation

yordis
Copy link
Contributor

@yordis yordis commented May 29, 2024

Definition of Ready

  • I am happy with the code
  • Short description of the feature/issue is added in the pr description
  • PR is linked to the corresponding user story
  • Acceptance criteria are met
  • All open todos and follow ups are defined in a new ticket and justified
  • Deviations from the acceptance criteria and design are agreed with the PO and documented.
  • Vitest unit tests ensure that components produce expected outputs on different inputs.
  • Cypress integration tests ensure that login app pages work as expected. The ZITADEL API is mocked.
  • No debug or dead code
  • My code has no repetitions

@vercel Vercel
Copy link

vercel bot commented May 29, 2024

@yordis is attempting to deploy a commit to the zitadel Team on Vercel.

A member of the Team first needs to authorize it.

@yordis yordis force-pushed the migrate-loginname branch from 6eeadf7 to 1946305 Compare May 29, 2024 20:07
@yordis yordis force-pushed the migrate-loginname branch from 1946305 to 7511dd3 Compare May 29, 2024 20:24
@yordis yordis closed this May 29, 2024
@yordis yordis deleted the migrate-loginname branch May 29, 2024 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
os-contribution
Projects
Product Management
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yordis @hifabienne