Enable Windows CI tests #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Little typo in commit message: "envrionement" |
trym-b
force-pushed
the
enable-tests-on-windows
branch
from
e4476b6
to
3f85f26
Compare
eskaur
reviewed
Jul 14, 2020
eskaur
reviewed
Jul 14, 2020
| import pytest | ||
|
|
||
|
|
||
| @pytest.mark.skipif( | ||
| platform.system() == "Windows", | ||
| reason=r"python: can't open file 'D:\a\samples\sample_capture_from_file.py': [Errno 2] No such file or directory", |
There was a problem hiding this comment.
Maybe you can make an issue to investigate this further later.
There was a problem hiding this comment.
It is hard to find the link between this code and #82.
- Investigate why running samples fails on windows #82 should mention that these two tests should be re-enabled.
- The
reasonhere should reference Investigate why running samples fails on windows #82.
There was a problem hiding this comment.
It looks like this is already addressed in #85. No need to do anything with this now, but in general, it is a good rule to never leave loose ends around in master. Often they are not going to be cleaned up right away when things are still fresh in memory.
In order to run tests on Windows, Intel OpenCL runtime needs to be installed to run the tests on a compute device. It is also required to create a configuration file so that the tests are run on the CPU instead of a GPU (since there are no GPU available in azure-pipelines) Added update environment script in order to load the latest environment variables set by `Zivid-SDK` after successful installation. `PATH` environment variable must be updated befre running the tests. Ignored sample testing for windows, because of the following error: ``` python: can't open file 'D:\a\samples\sample_print_version_info.py': [Errno 2] No such file or directory ``` Ignored `winreg` import error, this module is not available on Linux
trym-b
force-pushed
the
enable-tests-on-windows
branch
from
3f85f26
to
2eeee66
Compare
|
Ready for next round @eskaur |
eskaur
approved these changes
Jul 14, 2020
|
Thank you for reviewing @eskaur |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to run tests on Windows, Intel OpenCL runtime needs to be
installed to run the tests on a compute device. It is also required to
create a configuration file so that the tests are run on the CPU instead
of a GPU (since there are no GPU available in azure-pipelines)
Added update environment script in order to load the latest envrionement
variables set by
Zivid-SDKafter successful installation.PATHenvironment variable must be updated befre running the tests.
Ignored sample testing for windows, because of the following error:
Ignored
winregimport error, this module is not available on Linux