Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor mockPassportData generation #198

Merged
merged 18 commits into from
Sep 14, 2024
Merged

refactor mockPassportData generation #198

merged 18 commits into from
Sep 14, 2024

Conversation

0xturboblitz
Copy link
Member

@0xturboblitz 0xturboblitz commented Sep 13, 2024 •
edited
Loading

  • Now using only genMockPassportData.ts to generate mock passport data
  • Tests in /common verify them
  • Add mock DSCs for ecdsa
  • Factor tests into unique files
  • dedup some utils
  • removes dependency on passportData.signatureAlgorithm and passportData.pubKey

solves #182

@0xturboblitz
refactor mockPassportData generation
8522682 
- Now using only genMockPassportData.ts
- Tests in `/common` verify them
- Mock DSCs for ecdsa
- Factor tests into unique files
- Broke register ecdsa sig verif, will fix
@0xturboblitz 0xturboblitz marked this pull request as draft September 13, 2024 16:31
@0xturboblitz 0xturboblitz marked this pull request as ready for review September 14, 2024 06:05
@0xturboblitz 0xturboblitz merged commit 7e0601a into dev Sep 14, 2024
1 check passed
@0xturboblitz 0xturboblitz deleted the refactor-passportData branch September 14, 2024 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@0xturboblitz