Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor circuits #203

Merged
merged 63 commits into from
Sep 20, 2024
Merged

Refactor circuits #203

merged 63 commits into from
Sep 20, 2024

Commits on Aug 27, 2024

  1. improve passport compatibility 

    - increase max padded econtent length to 640
- allow dynamic length signed_attr input
- update econtent/signed_attr vars to correctly match referenced data
- allow dynamic econtent hash position in signed_attr
    @michaelelliot
    michaelelliot committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    0c110bd View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2024

  1. add signatureAlgorithm.circom

    @remicolin
    remicolin committed Sep 14, 2024
    Configuration menu
    Copy the full SHA
    a121a78 View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2024

  1. delete old LeafHasher templates

    @remicolin
    remicolin committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    6e80cc6 View commit details
    Browse the repository at this point in the history

  2. refactor openpassport register circuits templates, correction of vari… 

    …able names eContent and signAttr
    @remicolin
    remicolin committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    ce48d1d View commit details
    Browse the repository at this point in the history

  3. move utils test from circuits/tests/utils to circuits/tests/other_cir… 

    …cuits
    @remicolin
    remicolin committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    1cd3729 View commit details
    Browse the repository at this point in the history

  4. fix typo in utils.ts

    @remicolin
    remicolin committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    f443a14 View commit details
    Browse the repository at this point in the history

  5. rename LeafHashing functions

    @remicolin
    remicolin committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    4702d3c View commit details
    Browse the repository at this point in the history

  6. implement new leaf hashing functions in circuits

    @remicolin
    remicolin committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    22c9248 View commit details
    Browse the repository at this point in the history

  7. hardcode bits key length for ecdsa certificates

    @remicolin
    remicolin committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    448732b View commit details
    Browse the repository at this point in the history

  8. hash data in generateInputs correctly

    @remicolin
    remicolin committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    8eb1115 View commit details
    Browse the repository at this point in the history

  9. add sha1 and rename constants

    @remicolin
    remicolin committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    23515d1 View commit details
    Browse the repository at this point in the history

  10. implement generic shaBytes static functions

    @remicolin
    remicolin committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    d915697 View commit details
    Browse the repository at this point in the history

  11. generic passportVerifier - dg1 check

    @remicolin
    remicolin committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    4850be9 View commit details
    Browse the repository at this point in the history

  12. implement new features in openpassport_register

    @remicolin
    remicolin committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    2b1071a View commit details
    Browse the repository at this point in the history

  13. add rsa_sha1 to new register circuits

    @remicolin
    remicolin committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    6082ae5 View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2024

  1. remove compute_pubkey_leaf.circom

    @remicolin
    remicolin committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    865bfe0 View commit details
    Browse the repository at this point in the history

  2. implement sha1 in shaBytes

    @remicolin
    remicolin committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    8750c26 View commit details
    Browse the repository at this point in the history

  3. import fixed circom_tester lib

    @remicolin
    remicolin committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    fa3a2e7 View commit details
    Browse the repository at this point in the history

  4. update build_register_circuits.sh with new path

    @remicolin
    remicolin committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    d79f1c2 View commit details
    Browse the repository at this point in the history

  5. implement signature verification

    @remicolin
    remicolin committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    efcf097 View commit details
    Browse the repository at this point in the history

  6. update MAX_PADDED_SIGNED_ATTR_LEN

    @remicolin
    remicolin committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    081bc04 View commit details
    Browse the repository at this point in the history

  7. add rsa-pss register circuit

    @remicolin
    remicolin committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    272dea5 View commit details
    Browse the repository at this point in the history

  8. move passport date templates

    @remicolin
    remicolin committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    9883afc View commit details
    Browse the repository at this point in the history

  9. update functions and template names with _ecdsa ending

    @remicolin
    remicolin committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    f488265 View commit details
    Browse the repository at this point in the history

  10. add bigInt/bytes/array/functions templates

    @remicolin
    remicolin committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    f3d85c9 View commit details
    Browse the repository at this point in the history

  11. remove zkemail imports

    @remicolin
    remicolin committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    dc000c3 View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2024

  1. implement custom MAX_PADDED_ECONTENT_LEN and MAX_PADDED_SIGNED_ATTR_L… 

    …EN for each sigalg
    @remicolin
    remicolin committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    896eda9 View commit details
    Browse the repository at this point in the history

  2. add register ecdsa_sha1

    @remicolin
    remicolin committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    db06db5 View commit details
    Browse the repository at this point in the history

  3. adapt secp256r1Verifier for sha1 circuits

    @remicolin
    remicolin committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    07acb08 View commit details
    Browse the repository at this point in the history

  4. update prove circuits

    @remicolin
    remicolin committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    445d167 View commit details
    Browse the repository at this point in the history

  5. adapt generate inputs for prove circuits

    @remicolin
    remicolin committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    22e0390 View commit details
    Browse the repository at this point in the history

  6. add dg2 hash verification

    @remicolin
    remicolin committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    f992143 View commit details
    Browse the repository at this point in the history

  7. adapt disclose to new circuits

    @remicolin
    remicolin committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    4deab71 View commit details
    Browse the repository at this point in the history

  8. pad dg2_hash to length 64, fix commitment generation

    @remicolin
    remicolin committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    eb46505 View commit details
    Browse the repository at this point in the history

  9. fix ofac tests

    @remicolin
    remicolin committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    67f124b View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2024

  1. move n and k out of generate inputs functions

    @remicolin
    remicolin committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    4521b3b View commit details
    Browse the repository at this point in the history

  2. add scope to public inputs

    @remicolin
    remicolin committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    ae6b089 View commit details
    Browse the repository at this point in the history

  3. switch econtent for eContent

    @remicolin
    remicolin committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    e39925c View commit details
    Browse the repository at this point in the history

  4. remove passport_verifier circuits

    @remicolin
    remicolin committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    9c3d497 View commit details
    Browse the repository at this point in the history

  5. clean circuits repo

    @remicolin
    remicolin committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    07a5b09 View commit details
    Browse the repository at this point in the history

  6. fix genMockPassportData.test.ts

    @remicolin
    remicolin committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    c78a541 View commit details
    Browse the repository at this point in the history

  7. split bitmap into selector_dg1 and selector_older_than, fix nullifier… 

    … generation in prove circuits
    @remicolin
    remicolin committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    a239169 View commit details
    Browse the repository at this point in the history

  8. merge dev branch into register-circuits

    @remicolin
    remicolin committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    6c84976 View commit details
    Browse the repository at this point in the history

  9. yarn format

    @remicolin
    remicolin committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    f8c6dc9 View commit details
    Browse the repository at this point in the history

  10. fix import issues

    @remicolin
    remicolin committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    b7f292e View commit details
    Browse the repository at this point in the history

  11. use circom v2.1.9 compiler in github action

    @remicolin
    remicolin committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    7e888d9 View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2024

  1. refactor dsc circuits

    @remicolin
    remicolin committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    11a2bc8 View commit details
    Browse the repository at this point in the history

  2. fix import issue

    @remicolin
    remicolin committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    aad89dc View commit details
    Browse the repository at this point in the history

  3. use VarShiftLeft instead of SelectSubArray

    @remicolin
    remicolin committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    0d988d2 View commit details
    Browse the repository at this point in the history

  4. adapt common scipts to new dsc circuits

    @remicolin
    remicolin committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    18764e9 View commit details
    Browse the repository at this point in the history

  5. update register circuit

    @remicolin
    remicolin committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    3404f8b View commit details
    Browse the repository at this point in the history

  6. update prove into register and/or disclose circuit

    @remicolin
    remicolin committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    715eee4 View commit details
    Browse the repository at this point in the history

  7. delete register circuits

    @remicolin
    remicolin committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    a26e806 View commit details
    Browse the repository at this point in the history

  8. uncomment tests

    @remicolin
    remicolin committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    8c1baf4 View commit details
    Browse the repository at this point in the history

  9. yarn format

    @remicolin
    remicolin committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    a2e4652 View commit details
    Browse the repository at this point in the history

  10. force git to rename

    @remicolin
    remicolin committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    a9f0322 View commit details
    Browse the repository at this point in the history

  11. force git to rename 2

    @remicolin
    remicolin committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    6e12d57 View commit details
    Browse the repository at this point in the history

  12. implement formatInput() in generateInputs

    @remicolin
    remicolin committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    a79a46d View commit details
    Browse the repository at this point in the history

  13. add --max-old-space-size=8192 flag to yarn test

    @remicolin
    remicolin committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    3329a6e View commit details
    Browse the repository at this point in the history

  14. uplgrade circom compiler version to 2.1.9

    @remicolin
    remicolin committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    bd41e57 View commit details
    Browse the repository at this point in the history

  15. yarn format

    @remicolin
    remicolin committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    e031dfe View commit details
    Browse the repository at this point in the history

  16. merge branch 'improve-compatibility' from Michael

    @remicolin
    remicolin committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    6685a2f View commit details
    Browse the repository at this point in the history

  17. Merge pull request #204 from zk-passport/refactor-circuits-merge-pr-m… 

    …ichael

merge pr michaelelliot
    @remicolin
    remicolin authored Sep 20, 2024
    Configuration menu
    Copy the full SHA
    2cd404c View commit details
    Browse the repository at this point in the history