Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/one time sbt contract #214

Merged
merged 3 commits into from
Oct 7, 2024
Merged

Feat/one time sbt contract #214

merged 3 commits into from
Oct 7, 2024

Conversation

motemotech
Copy link
Collaborator

@motemotech motemotech commented Oct 7, 2024 •
edited
Loading

  • Add OneTimeSBT.sol
    • This is the contract you can get verified attr after your pass thorough these verification below
      • Prove circuit
      • DSC circuit
      • Current time verification
      • blinded dsc commitment equality
    • Also, I added expiration date for this OneTimeSBT. I just set for 90 days, since CRL is published by ICAN every 90 days.
  • Add VerifiersManager.sol
    • This is the contract to manage different verifiers for each process and signature algorithm

remicolin
remicolin reviewed Oct 7, 2024
View reviewed changes
contracts/contracts/interfaces/IVerifiersManager.sol

error ZERO_ADDRESS();

struct RSAProveCircuitProof {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change 'RSAProveCircuitProof' for 'ProveCircuitProof' as ecdsa signature is also used to sign passports

@remicolin remicolin merged commit a9fe0d1 into dev Oct 7, 2024
@remicolin remicolin deleted the feat/one-time-sbt-contract branch October 7, 2024 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@remicolin remicolin remicolin left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@motemotech @remicolin