New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat/error-handling #24

Merged

zk-steve merged 2 commits into main from feat/error-handling

Apr 1, 2024

Owner

zk-steve commented Mar 10, 2024

No description provided.

github-advanced-security bot found potential problems

View reviewed changes

src/adapter/src/repositories/postgres/question_db.rs Fixed Show fixed Hide fixed

src/adapter/src/repositories/postgres/question_db.rs Fixed Show fixed Hide fixed

src/public/src/errors.rs Fixed Show fixed Hide fixed

src/public/src/errors.rs Fixed Show fixed Hide fixed

src/public/src/errors.rs Fixed Show fixed Hide fixed

thuan2172001 force-pushed the feat/error-handling branch 10 times, most recently from dc0c118 to df06024 Compare

March 13, 2024 15:22

zk-steve commented

View reviewed changes

Dockerfile Outdated Show resolved Hide resolved

zk-steve commented

View reviewed changes

src/public/src/main.rs Outdated Show resolved Hide resolved

thuan2172001 force-pushed the feat/error-handling branch 2 times, most recently from 7353589 to bcd08fa Compare

March 13, 2024 15:57

zk-steve commented

View reviewed changes

src/adapter/src/repositories/postgres/models/question.rs Outdated Show resolved Hide resolved

thuan2172001 force-pushed the feat/error-handling branch 2 times, most recently from 189a523 to 6daceb0 Compare

March 14, 2024 15:46

thuan2172001 self-requested a review

March 15, 2024 02:08

thuan2172001 approved these changes

View reviewed changes

zk-steve commented

View reviewed changes

src/grpc/build.rs Outdated Show resolved Hide resolved

zk-steve commented

View reviewed changes

src/grpc/src/grpc_client/gpt_answer.rs Outdated Show resolved Hide resolved

zk-steve commented

View reviewed changes

src/grpc/src/grpc_client/gpt_answer.rs Outdated Show resolved Hide resolved

zk-steve commented

View reviewed changes

src/grpc/src/grpc_client/gpt_answer.rs Outdated

+                      Self { client }
+                  }
+                  pub async fn get_instance() -> Result<Self, CoreError> {

Owner Author

zk-steve Mar 20, 2024

Should have its own error type

Collaborator

thuan2172001 Mar 23, 2024 •

edited

Loading

... in the future

zk-steve commented

View reviewed changes

src/grpc/src/grpc_client/gpt_answer.rs Outdated Show resolved Hide resolved

zk-steve commented

View reviewed changes

src/grpc/src/grpc_server/gpt_answer.rs Outdated Show resolved Hide resolved

zk-steve commented

View reviewed changes

src/public/src/main.rs Show resolved Hide resolved

zk-steve commented

View reviewed changes

src/adapter/src/repositories/postgres/question_db.rs Outdated Show resolved Hide resolved

zk-steve commented

View reviewed changes

src/core/src/entities/question.rs Outdated Show resolved Hide resolved

zk-steve commented

View reviewed changes

src/public/src/controllers/question.rs Outdated Show resolved Hide resolved

zk-steve commented

View reviewed changes

src/public/src/options.rs Outdated Show resolved Hide resolved

zk-steve commented

View reviewed changes

src/public/src/main.rs Outdated Show resolved Hide resolved

zk-steve commented

View reviewed changes

src/core/src/common/errors.rs Outdated Show resolved Hide resolved

zk-steve commented

View reviewed changes

src/adapter/src/repositories/grpc/gpt_answer_client.rs Show resolved Hide resolved

zk-steve commented

View reviewed changes

src/adapter/src/repositories/grpc/gpt_answer_client.rs Outdated Show resolved Hide resolved

zk-steve commented

View reviewed changes

src/public/src/controllers/question.rs Outdated Show resolved Hide resolved

zk-steve commented

View reviewed changes

src/gpt_answer_server/src/main.rs Outdated Show resolved Hide resolved

zk-steve commented

View reviewed changes

src/gpt_answer_server/src/main.rs Outdated Show resolved Hide resolved

thuan2172001 force-pushed the feat/error-handling branch 10 times, most recently from ca65d4a to 199313a Compare

March 31, 2024 13:23

zk-steve commented

View reviewed changes

src/public/src/router.rs Outdated Show resolved Hide resolved

thuan2172001 force-pushed the feat/error-handling branch from 199313a to a50a9fa Compare

April 1, 2024 02:10


          feat: error handling

4fbc48c

feat: grpc server

Co-authored-by: Trinh Van Thuan <[email protected]>

zk-steve force-pushed the feat/error-handling branch 5 times, most recently from 4f85328 to 01f7e67 Compare

April 1, 2024 02:32


          fix: refine

f44d9eb

thuan2172001 force-pushed the feat/error-handling branch from 01f7e67 to f44d9eb Compare

April 1, 2024 02:45

zk-steve merged commit 4554da0 into main

9 checks passed

zk-steve deleted the feat/error-handling branch

April 1, 2024 06:40

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet