Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: updates for how-to tutorials #20

Merged
merged 2 commits into from
Jun 3, 2024
Merged

docs: updates for how-to tutorials #20

merged 2 commits into from
Jun 3, 2024

Conversation

amelnytskyi
Copy link
Contributor

What 💻

  • Added fixed for "how-to" tutorials

Why ✋

  • Reason why first thing was added to PR
  • Reason why second thing was added to PR
  • Reason why third thing was added to PR

Evidence 📷

Include screenshots, screen recordings, or console output here demonstrating that your changes work as intended

@amelnytskyi amelnytskyi requested a review from a team as a code owner May 31, 2024 15:38
@amelnytskyi amelnytskyi self-assigned this May 31, 2024
@amelnytskyi amelnytskyi requested a review from uF4No May 31, 2024 15:40
@github-actions GitHub Actions
Copy link

github-actions bot commented May 31, 2024 •
edited
Loading

Visit the preview URL for this PR (updated for commit 2c512f5):

https://community-cookbook-staging--pr20-qa-fix-how-to-tutori-l5mwr1lj.web.app

(expires Mon, 10 Jun 2024 08:41:23 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 1b876338aafcf55b4a02f1877984e116731756b1

uF4No
uF4No reviewed May 31, 2024
View reviewed changes
content/tutorials/how-to-withdraw-erc20/10.index.md Outdated
@@ -98,7 +98,7 @@ async function main() {
console.log(`Running script to bridge ERC-20 to L1`);

// Initialize the wallet.
const l1provider = new ethers.Provider(L1_RPC_ENDPOINT);
const l1provider = new Provider(L1_RPC_ENDPOINT);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const l1provider = new Provider(L1_RPC_ENDPOINT);
const l1provider = new ethers.JsonRpcProvider(L1_RPC_ENDPOINT);

This should be a provider from ethers, not zksync-ethers. Please try this suggestion

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in the latest commit

itsacoyote
itsacoyote requested changes May 31, 2024
View reviewed changes
content/tutorials/how-to-deposit-erc20/10.index.md Show resolved Hide resolved
content/tutorials/how-to-deposit-eth/10.index.md Outdated
@@ -76,7 +76,7 @@ dotenv.config();

// HTTP RPC endpoints
const L1_RPC_ENDPOINT = process.env.L1_RPC_ENDPOINT || ""; // or an RPC endpoint from Infura/Chainstack/QuickNode/etc.
const L2_RPC_ENDPOINT = process.env.L2_RPC_ENDPOINT || "https://testnet.era.zksync.dev"; // or the zkSync Era mainnet
const L2_RPC_ENDPOINT = process.env.L2_RPC_ENDPOINT || "https://sepolia.era.zksync.dev"; // or the zkSync Era mainnet
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here - %%zk_testnet_rpc_url%%

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in the latest commit

content/tutorials/how-to-withdraw-erc20/10.index.md Outdated
@@ -72,7 +72,7 @@ dotenv.config();

// HTTP RPC endpoints
const L1_RPC_ENDPOINT = process.env.L1_RPC_ENDPOINT || ""; // or an RPC endpoint from Infura/Chainstack/QuickNode/etc.
const L2_RPC_ENDPOINT = process.env.L2_RPC_ENDPOINT || "https://testnet.era.zksync.dev"; // or the zkSync Era mainnet
const L2_RPC_ENDPOINT = process.env.L2_RPC_ENDPOINT || "https://sepolia.era.zksync.dev"; // or the zkSync Era mainnet
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

%%zk_testnet_rpc_url%%

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in the latest commit

content/tutorials/how-to-withdraw-eth/10.index.md Outdated
@@ -72,7 +72,7 @@ dotenv.config();

// HTTP RPC endpoints
const L1_RPC_ENDPOINT = process.env.L1_RPC_ENDPOINT || ""; // or an RPC endpoint from Infura/Chainstack/QuickNode/etc.
const L2_RPC_ENDPOINT = process.env.L2_RPC_ENDPOINT || "https://testnet.era.zksync.dev"; // or the zkSync Era mainnet
const L2_RPC_ENDPOINT = process.env.L2_RPC_ENDPOINT || "https://sepolia.era.zksync.dev"; // or the zkSync Era mainnet
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

%%zk_testnet_rpc_url%%

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in the latest commit

@amelnytskyi
Copy link
Contributor Author

@uF4No @itsacoyote requested fixes added - could you please review?

uF4No
uF4No approved these changes Jun 3, 2024
View reviewed changes
Copy link
Contributor

@uF4No uF4No left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🫡

itsacoyote
itsacoyote approved these changes Jun 3, 2024
View reviewed changes
Copy link
Contributor

@itsacoyote itsacoyote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@itsacoyote itsacoyote merged commit 45615c6 into staging Jun 3, 2024
8 checks passed
@itsacoyote itsacoyote deleted the qa-fix-how-to-tutorials branch June 3, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uF4No uF4No uF4No approved these changes

@itsacoyote itsacoyote itsacoyote approved these changes

Assignees

@amelnytskyi amelnytskyi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amelnytskyi @itsacoyote @uF4No