Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update use of quickstart template #49

Merged
merged 2 commits into from
Aug 27, 2024
Merged

chore: update use of quickstart template #49

merged 2 commits into from
Aug 27, 2024

Conversation

jennyg0
Copy link
Contributor

@jennyg0 jennyg0 commented Aug 26, 2024

Description

update quickstart template to use zksync-101

Linked Issues

Additional context

@jennyg0 jennyg0 requested a review from a team as a code owner August 26, 2024 20:45
Copy link

github-actions bot commented Aug 26, 2024

Visit the preview URL for this PR (updated for commit b4d85a2):

https://community-cookbook-staging--pr49-remove-qs-dk75ymyw.web.app

(expires Tue, 03 Sep 2024 14:44:57 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 1b876338aafcf55b4a02f1877984e116731756b1

@jennyg0 jennyg0 requested a review from sarahschwartz August 26, 2024 20:51
Copy link
Contributor

@itsacoyote itsacoyote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's some modifications to the scripts that also need to be changed when using the zksync-101 template.

On line 272, the compile and deploy should now be:

yarn compile && yarn deploy:hello-zksync

@jennyg0 jennyg0 requested a review from itsacoyote August 27, 2024 14:43
@itsacoyote itsacoyote merged commit 2fbc60a into main Aug 27, 2024
11 checks passed
@itsacoyote itsacoyote deleted the remove-qs branch August 27, 2024 16:07
Copy link

🎉 This issue has been resolved in version 1.10.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants