Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(web3js): remove outdated Web3.js guide #52

Closed

Conversation

danforbes
Copy link
Contributor

Remove outdated Web3.js guide replaced by SDK docs

@danforbes danforbes requested a review from a team as a code owner August 28, 2024 17:17
Copy link
Contributor

@jennyg0 jennyg0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @danforbes, we updated this tutorial to include the new template if you want to review

@danforbes
Copy link
Contributor Author

hey @danforbes, we updated this tutorial to include the new template if you want to review

@jennyg0 - thank you so much, it looks great 🙏🏻 Should I go ahead and close out this PR, then?

@danforbes
Copy link
Contributor Author

@jennyg0 - I was reviewing the deployed/rendered docs and noticed that the Web3.js instance is being created with a ZKsync RPC URL, which is incorrect. Web3.js should be instantiated with an L1 RPC provider. I have opened #55 to address this issue.

@jennyg0 jennyg0 closed this Aug 29, 2024
@danforbes danforbes deleted the chore/web3js/remove branch August 29, 2024 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants