Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add test for multisig tutorial #76

Merged
merged 10 commits into from
Sep 23, 2024
Merged

Conversation

sarahschwartz
Copy link
Contributor

@sarahschwartz sarahschwartz commented Sep 16, 2024

  • updates & adds a test for the multisig tutorial
  • adds a code import plugin & replaces hard-coded code snippets with direct imports
  • minor small fixes

@sarahschwartz sarahschwartz self-assigned this Sep 16, 2024
Copy link

github-actions bot commented Sep 16, 2024

Visit the preview URL for this PR (updated for commit 37d0f79):

https://community-cookbook-staging--pr76-sarah-multisig-test-g7o5nqny.web.app

(expires Thu, 26 Sep 2024 15:29:08 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 1b876338aafcf55b4a02f1877984e116731756b1

@sarahschwartz sarahschwartz marked this pull request as ready for review September 16, 2024 17:40
@sarahschwartz sarahschwartz requested a review from a team as a code owner September 16, 2024 17:40
@sarahschwartz sarahschwartz marked this pull request as draft September 17, 2024 21:59
@sarahschwartz sarahschwartz marked this pull request as draft September 17, 2024 21:59
@sarahschwartz sarahschwartz marked this pull request as ready for review September 18, 2024 15:41
Copy link
Contributor

@dutterbutter dutterbutter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job! A couple nits / commentary.

code/multisig/contracts/AAFactory.sol Show resolved Hide resolved
code/multisig/contracts/TwoUserMultisig.sol Outdated Show resolved Hide resolved
code/multisig/template/Account.sol Show resolved Hide resolved
tests/utils/runCommand.ts Show resolved Hide resolved
@sarahschwartz sarahschwartz merged commit b46e863 into main Sep 23, 2024
13 checks passed
@sarahschwartz sarahschwartz deleted the sarah/multisig-test branch September 23, 2024 15:34
Copy link

🎉 This PR is included in version 1.14.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants