Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use base64 to encode/decode raw_metadata #74

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ShuiRuTian
Copy link
Contributor

Use base64 to fix #72

However, this is a breaking change, we could not read the origin data any more.

Should we also bump INDEX_VERSION? And what about migration?

Maybe we could provide a deserializer, which could deserialize both 2 different data type (array and string) to Vec, but there is no way to reuse existing Vec visitor, I guess we have to copy and paste, kind of dirty.

Any other concerns or thoughts?

@zkat
Copy link
Owner

zkat commented May 10, 2024

Yes, this is a breaking change, and yes, you'll have to bump INDEX_VERSION.

In general, I don't worry too much about migration because cacache is intended to be a cache, not persistent storage, so if you can't just throw everything away, you're probably using it wrong.

@ShuiRuTian
Copy link
Contributor Author

Sounds good.

I just fixed and bumped INDEX_VERSION, but I did not bump the version of this package, I guess it's more proper to leave this work to the real owner.

@zkat
Copy link
Owner

zkat commented May 12, 2024

Yeah, I'll do that next time I do a semver-major release :)

@zkat zkat added the semver-major Semver-breaking change label May 12, 2024
@ShuiRuTian
Copy link
Contributor Author

Hi @zkat, maybe we could release another major version? It's about 6 months since last release.

@ShuiRuTian
Copy link
Contributor Author

@zkat ping~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-major Semver-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"raw_metadata" is not raw after serialization
2 participants