Turns out, Report
*really* doesn't want to be an Error
or Diagnostic
...
#368
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Failing some context tests, I'm pretty sure because
self.wrap_err(msg)
creates acontext_chain_downcast
table, whilst theReport::from_msg(msg, self)
that it's impl clashed with only creates atcontext_downcast
.I messed around and got Rust to segfault, and discovered I was very much in over my head...
I do think it's possible to
impl Diagnostic for Report
, but there's a lot of internal restructuring that would need to happen, and in the best case, we lose theInto<Report>
impl.As with 90%+ of my issues with Rust nowadays, the stabilization of specialization would solve this (I believe), but that could be ages and ages away still...
Ultimately, this is here if anyone is feeling clever / brave, and it's work thinking about if we're okay losing those
From
andInto
impls forReport
, because I don't think there is a clever way around that...