Skip to content

Commit

Permalink
Add todo for module & remove unused error
Browse files Browse the repository at this point in the history
  • Loading branch information
JohnGuilding committed Jun 19, 2024
1 parent 0c6aaf9 commit 299c3d5
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/modules/EmailRecoveryModule.sol
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ contract EmailRecoveryModule is ERC7579ExecutorBase, IRecoveryModule {
event NewValidatorRecovery(address indexed validatorModule, bytes4 recoverySelector);
event RemovedValidatorRecovery(address indexed validatorModule, bytes4 recoverySelector);

error CanOnlySetManagerOnce();
error InvalidSelector(bytes4 selector);
error InvalidOnInstallData();
error InvalidValidator(address validator);
Expand Down Expand Up @@ -75,6 +74,7 @@ contract EmailRecoveryModule is ERC7579ExecutorBase, IRecoveryModule {
uint256 expiry
) = abi.decode(data, (address, bytes4, address[], uint256[], uint256, uint256, uint256));

// TODO: Should isInstalledContext be passed in?
allowValidatorRecovery(validator, bytes("0"), initialSelector);

_execute({
Expand Down Expand Up @@ -160,7 +160,7 @@ contract EmailRecoveryModule is ERC7579ExecutorBase, IRecoveryModule {
revert InvalidValidatorsLength();
}

// TODO: unit test
// TODO: test
// if (next != ZERO_ADDRESS) {
if (next != SENTINEL) {
revert InvalidNextValidator();
Expand Down

0 comments on commit 299c3d5

Please sign in to comment.