Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Update callling function name in DeployEmailRecoveryModuleScript. #20

Closed
wants to merge 4 commits into from
Closed

chore: Update callling function name in DeployEmailRecoveryModuleScript. #20

wants to merge 4 commits into from

Conversation

wshino
Copy link
Contributor

@wshino wshino commented Jul 4, 2024

Clave wallet needs resetOwners(bytes) calling not changeOwner(address).

@wshino wshino changed the title Update callling function name in DeployEmailRecoveryModuleScript. chore: Update callling function name in DeployEmailRecoveryModuleScript. Jul 4, 2024
@SoraSuegami
Copy link
Contributor

Could you take the selector name from env and set its default value changeOwner(address)?
As the script is used for various wallets, I think it is better to manually put resetOwners(bytes) as the env for clave wallets than hardcoding it.

@JohnGuilding
Copy link
Collaborator

This change is not needed

@JohnGuilding JohnGuilding deleted the feat/change-call-function-name branch August 14, 2024 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wshino @SoraSuegami @JohnGuilding