Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ackee audit fixes #22

Merged
merged 30 commits into from
Aug 1, 2024
Merged

Ackee audit fixes #22

merged 30 commits into from
Aug 1, 2024

Commits on Jul 16, 2024

  1. H1: Multiple vulnerabilities in recovery configuration process

    @JohnGuilding
    JohnGuilding committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    4fd94ba View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2024

  1. H2: Premature guardian configuration update in addGuardian function

    @JohnGuilding
    JohnGuilding committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    b31a844 View commit details
    Browse the repository at this point in the history

  2. M1: templateIdx function parameter check is in incorrect place

    @JohnGuilding
    JohnGuilding committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    06bf755 View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2024

  1. M2: Maximum guardians DoS

    @JohnGuilding
    JohnGuilding committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    ba217b6 View commit details
    Browse the repository at this point in the history

  2. M4: MAX + 1 validators may be configured in 

    UniversalEmailRecoveryModule
    @JohnGuilding
    JohnGuilding committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    5f1fc9e View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2024

  1. Fix simulate test bug

    @JohnGuilding
    JohnGuilding committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    ad4fc63 View commit details
    Browse the repository at this point in the history

  2. L1: Validators can be added/removed before module initialization in U… 

    …niversalEmailRecovery
    @JohnGuilding
    JohnGuilding committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    9b235d8 View commit details
    Browse the repository at this point in the history

  3. L2: Validators cannot be disallowed after being uninstalled in Univer… 

    …salEmailRecovery
    @JohnGuilding
    JohnGuilding committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    184f5e5 View commit details
    Browse the repository at this point in the history

  4. Add missing error selectors from helper test

    @JohnGuilding
    JohnGuilding committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    b1811d4 View commit details
    Browse the repository at this point in the history

  5. L3: cancelRecovery does not revert when no recovery is in process

    @JohnGuilding
    JohnGuilding committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    8f3fa22 View commit details
    Browse the repository at this point in the history

  6. W1: isInitialized function returns false if initialized without guard… 

    …ians
    @JohnGuilding
    JohnGuilding committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    0e4234c View commit details
    Browse the repository at this point in the history

Commits on Jul 22, 2024

  1. W2: Unused bytes32 function parameter in EmailRecoveryManager

    @JohnGuilding
    JohnGuilding committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    c9028df View commit details
    Browse the repository at this point in the history

Commits on Jul 23, 2024

  1. W3: Unnecessary computation of calldataHash value in validateRecovery… 

    …Subject function
    @JohnGuilding
    JohnGuilding committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    f80edd7 View commit details
    Browse the repository at this point in the history

  2. W5: Events missing parameters

    @JohnGuilding
    JohnGuilding committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    bc1410a View commit details
    Browse the repository at this point in the history

  3. W6: Missing AddedGuardian event emission in setupGuardians function

    @JohnGuilding
    JohnGuilding committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    8a4afd8 View commit details
    Browse the repository at this point in the history

  4. W7: ERC-4337 violation in onInstall

    @JohnGuilding
    JohnGuilding committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    c8d8686 View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2024

  1. I1: getTrustedRecoveryManager function returns public variable emailR… 

    …ecoveryManager
    @JohnGuilding
    JohnGuilding committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    7dff8fc View commit details
    Browse the repository at this point in the history

  2. I2: Non-immutable state variables in 

    EmailRecoveryManager
    @JohnGuilding
    JohnGuilding committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    c750719 View commit details
    Browse the repository at this point in the history

  3. I3: Misleading naming

    @JohnGuilding
    JohnGuilding committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    51755ee View commit details
    Browse the repository at this point in the history

  4. I4: Unchecked return values in EnumerableGuardianMap library

    @JohnGuilding
    JohnGuilding committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    4c3a5bb View commit details
    Browse the repository at this point in the history

  5. I5: Use calldata in favor of memory in function parameters

    @JohnGuilding
    JohnGuilding committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    cd22e1f View commit details
    Browse the repository at this point in the history

  6. I7: Missing zero-address validation in constructors

    @JohnGuilding
    JohnGuilding committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    142452a View commit details
    Browse the repository at this point in the history

  7. I8: Modifiers not above constructors

    @JohnGuilding
    JohnGuilding committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    2ec79b9 View commit details
    Browse the repository at this point in the history

  8. I9: Safe validateRecoverySubject optimization

    @JohnGuilding
    JohnGuilding committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    5ec1cfa View commit details
    Browse the repository at this point in the history

  9. I10: Unused using-for directive

    @JohnGuilding
    JohnGuilding committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    cef7751 View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2024

  1. Add missing zero address check

    @JohnGuilding
    JohnGuilding committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    397e64c View commit details
    Browse the repository at this point in the history

Commits on Jul 28, 2024

  1. M3: Selector collisions in 

    UniversalEmailRecoveryModule
    @JohnGuilding
    JohnGuilding committed Jul 28, 2024
    Configuration menu
    Copy the full SHA
    9c7db07 View commit details
    Browse the repository at this point in the history

  2. W4: Gas inefficiencies in UniversalRecoveryModule

    @JohnGuilding
    JohnGuilding committed Jul 28, 2024
    Configuration menu
    Copy the full SHA
    d24daeb View commit details
    Browse the repository at this point in the history

Commits on Jul 29, 2024

  1. Fix build warnings

    @JohnGuilding
    JohnGuilding committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    88371b8 View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2024

  1. Add additional selector checks to modules

    @JohnGuilding
    JohnGuilding committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    5b26a9a View commit details
    Browse the repository at this point in the history