Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/native safe recovery module #24

Merged
merged 5 commits into from
Aug 8, 2024
Merged

Feat/native safe recovery module #24

merged 5 commits into from
Aug 8, 2024

Conversation

JohnGuilding
Copy link
Collaborator

@JohnGuilding JohnGuilding commented Jul 30, 2024 •
edited
Loading

  • Add native Safe module
  • Make configureRecovery function in manager public instead of internal so it can be called for the native Safe module. This is because Safe modules do not have an equivalent to the onInstall function
  • Add native Safe recovery module integration tests

wshino
wshino reviewed Aug 1, 2024
View reviewed changes
Copy link
Contributor

@wshino wshino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one comment.

script/DeploySafeNativeRecovery.s.sol Outdated Show resolved Hide resolved
@JohnGuilding JohnGuilding force-pushed the feat/native-safe-recovery-module branch from 92eea21 to 1ca7842 Compare August 1, 2024 21:25
@JohnGuilding JohnGuilding changed the base branch from main to feat/additional-integration-tests August 1, 2024 21:26
Base automatically changed from feat/additional-integration-tests to main August 5, 2024 19:21
@JohnGuilding JohnGuilding force-pushed the feat/native-safe-recovery-module branch from afa7259 to 4197d1e Compare August 7, 2024 11:55
@JohnGuilding JohnGuilding changed the base branch from main to fix/encode-validator-with-recovery-calldata August 7, 2024 12:02
@JohnGuilding JohnGuilding force-pushed the feat/native-safe-recovery-module branch from 4197d1e to 772ce93 Compare August 7, 2024 14:18
@JohnGuilding JohnGuilding changed the base branch from fix/encode-validator-with-recovery-calldata to fix/recover-multiple-validators August 7, 2024 14:19
@JohnGuilding JohnGuilding force-pushed the feat/native-safe-recovery-module branch from 772ce93 to 730abb1 Compare August 7, 2024 14:35
@JohnGuilding JohnGuilding marked this pull request as ready for review August 7, 2024 16:20
wshino
wshino approved these changes Aug 8, 2024
View reviewed changes
Copy link
Contributor

@wshino wshino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Base automatically changed from fix/recover-multiple-validators to main August 8, 2024 08:26
@JohnGuilding JohnGuilding merged commit 2b716bd into main Aug 8, 2024
4 checks passed
@JohnGuilding JohnGuilding deleted the feat/native-safe-recovery-module branch August 8, 2024 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wshino wshino wshino approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JohnGuilding @wshino