Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/add custom error arguments #25

Merged
merged 1 commit into from
Aug 1, 2024

Conversation

JohnGuilding
Copy link
Collaborator

@JohnGuilding JohnGuilding commented Jul 30, 2024

No description provided.

@JohnGuilding JohnGuilding changed the base branch from main to ackee-audit-fixes July 31, 2024 14:46
@JohnGuilding JohnGuilding marked this pull request as ready for review July 31, 2024 14:46
@JohnGuilding JohnGuilding force-pushed the feat/add-custom-error-arguments branch from 0b5121f to a388fff Compare August 1, 2024 09:28
Copy link
Contributor

@wshino wshino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

error RecoveryRequestExpired();
error InvalidCalldataHash();
error NotEnoughApprovals(uint256 currentWeight, uint256 threshold);
error DelayNotPassed(uint256 blockTimestamp, uint256 executeAfter);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these changes increase readability to these events.

Base automatically changed from ackee-audit-fixes to main August 1, 2024 13:41
@JohnGuilding JohnGuilding merged commit f2ab698 into main Aug 1, 2024
4 checks passed
@JohnGuilding JohnGuilding deleted the feat/add-custom-error-arguments branch August 1, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants