Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/body parsing #45

Merged
merged 86 commits into from
Nov 3, 2024
Merged

Feat/body parsing #45

merged 86 commits into from
Nov 3, 2024

Conversation

SoraSuegami
Copy link
Contributor

No description provided.

@JohnGuilding
Copy link
Collaborator

Soft approve of these changes. Will approve formally once audit is over and review any additional changes

@JohnGuilding
Copy link
Collaborator

@SoraSuegami can we mark this as ready for review?

Copy link

openzeppelin-code bot commented Oct 25, 2024

Feat/body parsing

Generated at commit: 2461bbbac9524159f4738db5bb8f7d3dbc5be248

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total
0
0
0
3
16
19
Dependencies Critical
High
Medium
Low
Note
Total
0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector

@@ -35,7 +35,7 @@ contract DeploySafeRecoveryWithAccountHiding_Script is BaseDeployScript {
IERC7484 registry = IERC7484(0xe0cde9239d16bEf05e62Bbf7aA93e420f464c826);

vm.startBroadcast(vm.envUint("PRIVATE_KEY"));
verifier = address(0);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch

@SoraSuegami SoraSuegami merged commit dae2bf3 into main Nov 3, 2024
7 checks passed
@SoraSuegami SoraSuegami deleted the feat/body-parsing branch November 3, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants