Feat/test improvements #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wshino
reviewed
Oct 21, 2024
| @@ -14,6 +14,7 @@ | |||
| "not-rely-on-time": "off", | |||
| "one-contract-per-file": "off", | |||
| "var-name-mixedcase": "off", | |||
| "immutable-vars-naming": "off" | |||
| "immutable-vars-naming": "off", | |||
| "no-console": "warn" | |||
There was a problem hiding this comment.
Thank you, I sometimes forget to remove the console.log
wshino
reviewed
Oct 21, 2024
| @@ -25,35 +23,38 @@ contract EmailRecoveryManager_Integration_Test is | |||
| } | |||
|
|
|||
| function test_RevertWhen_HandleAcceptanceCalled_BeforeConfigureRecovery() public { | |||
There was a problem hiding this comment.
Is it okay to remove this vm.prank?
There was a problem hiding this comment.
Yeah it is unnecessary when calling instance1.uninstallModule and similar functions on instance1
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
Might be a difficult one to review without good context on how the tests are structured. Would try:
Base.t.solhas everything you would expectcomputeEmailAuthAddressas that is a virtual function inBase.t.soland is implemented in other base testsdeployModuleas that is a virtual function inBase.t.soland is implemented in other base testsThere is still some work to be done here, for example abstracting away
handleRecoveryhelper functions into fewer base test files. That will be covered in a future PR that can be merged on top of the audit fixes