-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add string utils to ether-email-auth #76
Merged
SoraSuegami
merged 2 commits into
feat/body-parsing-with-audit-fix
from
feat/update-and-move-string-utils
Oct 30, 2024
Merged
Add string utils to ether-email-auth #76
SoraSuegami
merged 2 commits into
feat/body-parsing-with-audit-fix
from
feat/update-and-move-string-utils
Oct 30, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add string utils to ether-email-auth
🚨 Report Summary
For more details view the full report in OpenZeppelin Code Inspector |
SoraSuegami
approved these changes
Oct 30, 2024
SoraSuegami
merged commit Oct 30, 2024
25b830e
into
feat/body-parsing-with-audit-fix
5 checks passed
SoraSuegami
added a commit
that referenced
this pull request
Nov 3, 2024
* feat: email_auth body parsing circuit working with tests * fix: minor test changes * chore: update dependencies * (wip) chore: pass github workflow * Add a verifier contract * Update proving key url * feat: add body parsing * chore: update * chore: separated body parsing tests * fix: refactring in recipent_enabled test * fix: minor * chore: update relayer * fix: updated command regex * chore: changed max_command_bytes to 605 * Update verifier * feat: sha precompute test * chore: update relayer utils version * feat: command update + relayer changes * Fix circuit name in core.py * chore: update version * chore: update circuit test * chore: update relayer-uitls dep * Update verifier * Change the max header/body sizes in the body-parsing circuits. * Add test circuits for body parsing * Update verifier * Fixing integration test * Update emails for integration tests * Update yarn.lock * Fix scripts and email for integration test * chore: update circuit test * Integration test worked * fix: body parsing test * feat: complete flow * Replace subject with command. * Fix compile errors in relayer * Remove skipped_command_bytes * Merge audit-fix into body-parsing * Add IGroth16Verifier * Recover skipped_commad_bytes * Apply audit-fixes to the body-parsing circuit. * Fix relayer * Disable auto script tests in contracts * Update verifier and proving key * Feat/fix zksync impl (#60) * Fix yarn zkbuild * Fix yarn zktest * Fix integration test except for eml files * comment out specific zksync lines * Update test emails for zksync * Update integration test for zksync * Update bytecode hash * Update proof.json path * Update publicInputFile path * Update bytecode hash * Update docs for integration tests for zksync * Update package.json in contracts * Let functions in EmailAccountRecoveryZKSync be virtual * fix: subject template parsing * Add requestGuardian to SimpleWallet * Fix scripts * Fix scripts * Update READMEs * Fix circuit package.json * Fix typo and remove unnecessary file * Remove space from invitation code * chore: refactor * WIP: Add custom errors * Update .env.example * Split up handle_email fn; Remove code duplication * Custom errors for email * Rebase solve conflicts of body-parser refacor * Rebase solve conflicts of body-parser refacor * Rebase fixes * Acknowledgement as replies in email thread * Add Re: to subject for reply emails * Update email templates UI * Add cloud build to build on gcp * Bump relayer version * fix: add command in email templates * feat: add CONTRIBUTING.md & CODING_GUIDELINES.md * chore: move md files * feat: add github workflows * chore: remove abis * chore: update github actions and add PR template * fix: github action * Remove hard-coded file_paths; Fix clippy warnings * Move util files from ether-email-auth to utils repo * Fix relayer-utils version to refactor commit * Force db initialization on startup * AI generated doc comments * Prevent duplicates by checking if it is a valid reply * Add AI generated comments * Rename func to extract_template_vals_from_command * Exclude abi folder as workspace member * Ignore abis for fmt * Add github actions to build docker image * ui: Update email template UI - powered by zk email is odd that theyre different sizes - the social icons at the bottom look squished - Update the email template from The Zk team Aayush to The ZK Email Team - Check vertical padding in the mail * feat: GPU prover (#66) * feat: use GPU for proving * chore: update Dockerfile * chore: cleanup * chore: update params.zip * chore: update circom_proofgen.sh * chore: update * fix: regex json path * chore: update k8s manifest * feat: use GPU for proving * chore: add comment in example env * feat: keep modal warm * ui: update email template design * chore: cleanup * chore: update dockerignore * chore: update dockerignore * chore: update k8s manifest * Add an invalid utf8 test email * Update circom_tester * Fix circom version * Fix circom version * Make test cases as a function named files * Add test cases for DKIM registries * Add test cases for EmailAccountRecovery * Add general test cases * Update proxy bytecode hash * Add more events * Fix circom version to 2.1.9 in github action * audit fixes * Fix email_auth_with_recipient * Add send_email.py for test * Add upgrade test * Update circom tests * Fix recipient test * Fix circom import in email_auth.circom * Fix arg name in removePrefix * Update dependencies * Fix interfaces to call EmailVerifier. * Change the regex of forced_subject * change the positon dependency in forced_subject * Add "ZK" to the relayer's email subjects * Fix force_subject regex error * Integration test on base worked. * update version * Update integration test emails * Fix zksync intergation test * Not hardcode proxyBytecodeHash in EmailAccountRecoveryZKSync * Update prover * Update README and call args for RecoveryControllerZKSync * Change forced_subject to accept "Re: " * Update zk-email circuits/contracts versions * Add RequestGuardianSimpleWallet script * add test_forced_subject_regex * Update test emails for integration tests * Remove console from EmailAuth * remove console.log * Use PROXY_BYTECODE_HASH in .env * Use default bytes32 value if PROXY_BYTECODE_HASH is not set * if PROXY_BYTECODE_HASH it not set the script will revert * Update verifier * Update versions * relayer update * Update prover with gpus * Update prover * chore: node version >=18 * chore: prover * Revert "Update prover" This reverts commit 9b3e29c. * Revert "Update prover with gpus" This reverts commit b00f205. * Update prover version * chore: change gpu * Update dkim registries * Update integration test * Update scripts to use useroverriable registry * E2E test with user overridable dkim registry worked. * Remove DeployCommonScript * Fix integration test for foundry * Fix IntegrationZKSync * Update dependency * Update yarn.lock * chore: update * chore: update version & Cargo.lock * Remove ForwardDKIMRegistry and Add scripts for UseroverridableDKIMRegistry * Fix relayer * Remove ForwardDKIMRegistry.sol * Update yarn.lock * Update yarn.lock * Fix clippy bug * Fix integration test for zksync era-test-node * Remove code which relates to ForwardDKIMRegistry * Abstract Verifier as IVerifier * Update test signature for test_Dfinity_Oracle_Response * Fix script test errors * chore: update * Update circuit depndencies * chore: update version * downgrade typescript * Format * Remove setEnv from DeployRecoveryController * Specify commits in zk-email-verify * Update version * Remove testRequestGuardianNotOwner and add verifier test case for upgrading * Fix test_Revert_IfSignatureIsInvalid * Update zk-email/contracts repo hash * Update zk-regex and circuit tests * update zk-email/circuit and contract * Update verifier and integration tests * Update prover * Use wasm&cpu for the prover temporarily. * Fix chain.rs for updates of Useroverridable dkim registry * Fix the forced subject * Update versions * Add gas limit param (#75) * Send cycles to call the dkim canister function * remove warning * fix warning * Add string utils to ether-email-auth (#76) * Add string utils to ether-email-auth * Install solidity string utils * Feat/audit fix 2024 09 gpus (#77) * update prover * Fix prover * update local_setup.sh * Update circom_proofgen.sh * Disable logger temporary * Fix dockerfile and scripts * Update zk-email/contracts * Fix script * Feat/deploy via oz defender (#73) * forge install: openzeppelin-foundry-upgrades v0.3.6 * forge install: openzeppelin-contracts-upgradeable v5.1.0 * Test OZ Defender WIP * Add package.json * Add unsafeSkipAllChecks * Remove @openzeppelin/upgrades-core * remove OZ upgradeable submodule * Finish updating scripts * Clean up * Remove vm.setEnv from script * Remove use of setEnv in deployment script --------- Co-authored-by: wshino <[email protected]> Co-authored-by: SoraSuegami <[email protected]> * update version * Use the address from deployerPrivateKey if no initialOwner is provided. * Fix BaseDeployScript * Update integration test * Feat/improve alerts (#72) * Send mail if contract call failed * Apply cargo fmt * Add logic to mail a user error email to system user's address * Revert send_email function to private * Add more info for error in recover function * Add PROVER_ADDRESS to yaml files for kubernetes * Fix env name * Add env * Remove duplicate tr * Apply cargo fmt * Fix cargo clippy warnings * Add metrics and alerts as file * Add support section (#78) * Feat/add emergency docs (#71) * Add doc for emergency * Rename emergency.md -> upgrade.md * Feat/e2e zksync (#79) * Update missing libraries in README.md and remove defender import * Remove OZ Defender dependencies * remove console in StringUtils * Import StringUtils in CommandUtils * Feat/fix zksync commands (#80) * Update testcases which uses era-test-node * Fix LLVM problems * Update foundry.toml * Update zkbuild and zktest commands * Update README.md * Add install era-test-node in README.md * Export a circuit with body parsing and the recipient feature. * Push the missing circuit * Add one more circuit test * Separate tests for the recipient --------- Co-authored-by: shreyas-londhe <[email protected]> Co-authored-by: Aditya Bisht <[email protected]> Co-authored-by: Aditya Bisht <[email protected]> Co-authored-by: wshino <[email protected]> Co-authored-by: Yush G <[email protected]> Co-authored-by: Dimitri <[email protected]> Co-authored-by: Shubham Gupta <[email protected]> Co-authored-by: John Guilding <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.