Merge branch 'feat/body-parsing-with-audit-fix' of https://github.com…

…/zkemail/ether-email-auth into feat/body-parsing-with-audit-fix
zkemail · Sep 12, 2024 · 4adb046 · 4adb046
2 parents 9104be6 + 6607fd2
commit 4adb046
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 4 deletions.
diff --git a/packages/contracts/README.md b/packages/contracts/README.md
@@ -362,6 +362,8 @@ forge create src/libraries/CommandUtils.sol:CommandUtils --private-key {YOUR_PRI
 
 Set the libraries in foundry.toml using the above deployed address.
 
+Due to this change in the address of the missing libraries, the value of the proxyBytecodeHash must also be changed: change the value of the proxyBytecodeHash in E-mailAccountRecoveryZKSync.sol.
+
 And then, run the integration testing.
 
 ```

diff --git a/packages/contracts/src/EmailAccountRecoveryZKSync.sol b/packages/contracts/src/EmailAccountRecoveryZKSync.sol
@@ -16,6 +16,7 @@ abstract contract EmailAccountRecoveryZKSync is EmailAccountRecovery {
     // If you failed some test cases, check the bytecodeHash by yourself
     // see, test/ComputeCreate2Address.t.sol
     bytes32 public constant proxyBytecodeHash = 0x010000835b32e9a15f4b6353ad649fa33f4fbe4f5139126c07205e738b9f758e;
+
     /// @notice Returns the address of the zkSyncfactory contract.
     /// @dev This function is virtual and can be overridden by inheriting contracts.
     /// @return address The address of the zkSync factory contract.

diff --git a/packages/contracts/test/IntegrationZKSync.t.sol b/packages/contracts/test/IntegrationZKSync.t.sol
@@ -169,7 +169,7 @@ contract IntegrationZKSyncTest is Test {
         string memory publicInputFile = vm.readFile(
             string.concat(
                 vm.projectRoot(),
-                "/test/build_integration/email_auth_public.json"
+                "/test/build_integration/email_auth_with_body_parsing_with_qp_encoding_public.json"
             )
         );
         string[] memory pubSignals = abi.decode(
@@ -190,7 +190,7 @@ contract IntegrationZKSyncTest is Test {
         emailProof.proof = proofToBytes(
             string.concat(
                 vm.projectRoot(),
-                "/test/build_integration/email_auth_proof.json"
+                "/test/build_integration/email_auth_with_body_parsing_with_qp_encoding_proof.json"
             )
         );
 
@@ -251,7 +251,7 @@ contract IntegrationZKSyncTest is Test {
         publicInputFile = vm.readFile(
             string.concat(
                 vm.projectRoot(),
-                "/test/build_integration/email_auth_public.json"
+                "/test/build_integration/email_auth_with_body_parsing_with_qp_encoding_public.json"
             )
         );
         pubSignals = abi.decode(vm.parseJson(publicInputFile), (string[]));
@@ -275,7 +275,7 @@ contract IntegrationZKSyncTest is Test {
         emailProof.proof = proofToBytes(
             string.concat(
                 vm.projectRoot(),
-                "/test/build_integration/email_auth_proof.json"
+                "/test/build_integration/email_auth_with_body_parsing_with_qp_encoding_proof.json"
             )
         );