Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add download test #11

Merged
merged 4 commits into from
Feb 5, 2024
Merged

Add download test #11

merged 4 commits into from
Feb 5, 2024

Conversation

isidroamv
Copy link
Collaborator

@isidroamv isidroamv commented Feb 4, 2024

This PR solves part of the issues reported in the issue-9:

Changes:

  • Moves alchemy key into secrets
  • Adds the test for download functionality into the CI

CC: @Divide-By-0 , @saleel

Copy link

render bot commented Feb 4, 2024

@isidroamv isidroamv changed the title Update test Add download test Feb 4, 2024
@saleel saleel mentioned this pull request Feb 5, 2024
@saleel
Copy link
Member

saleel commented Feb 5, 2024

Thank you.

I have been trying this, and the Job was getting timed out even though the log says it finished all steps - https://github.com/zkemail/proof-of-twitter/actions/runs/7728773573/job/21075860938

Looks like the trick is to set the args and executablePath like you did.

@saleel saleel merged commit 5b1a4c4 into main Feb 5, 2024
4 checks passed
@saleel saleel deleted the issue-9/update-test branch February 5, 2024 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants