Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add range check for usernameIndex and fromIndex #33

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

saleel
Copy link
Member

@saleel saleel commented Sep 8, 2024

No description provided.

Copy link

vercel bot commented Sep 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
proof-of-twitter ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 8, 2024 6:47pm

@SoraSuegami
Copy link

I think your code changes are good!
However, the e2e test makes TimeoutError: Waiting for selector [data-testid='status-proof-files-downloaded-successfully' failed: Waiting failed: 1000000ms exceeded error.

@saleel
Copy link
Member Author

saleel commented Sep 9, 2024

I think your code changes are good! However, the e2e test makes TimeoutError: Waiting for selector [data-testid='status-proof-files-downloaded-successfully' failed: Waiting failed: 1000000ms exceeded error.

Yea, this is a historical bug where it fails in Github but pass locally. I am not sure why this is happening (didnt debug much), but not related to changes in this PR.

@saleel saleel merged commit bfda11b into main Sep 9, 2024
5 of 6 checks passed
@saleel saleel deleted the circuit/add-range-check branch September 9, 2024 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants