Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Add Github actions #6

Merged
merged 2 commits into from
Dec 21, 2023
Merged

ci: Add Github actions #6

merged 2 commits into from
Dec 21, 2023

Conversation

isidroamv
Copy link
Collaborator

No description provided.

@isidroamv
Copy link
Collaborator Author

@Divide-By-0 Please add the variable ALCHEMY_API_KEY in the project config and re-run the test. In addition, configure the project to block merges if the tests don't pass.

@isidroamv
Copy link
Collaborator Author

@Divide-By-0 Could you please configure the environment variable as the image below?
Screenshot 2023-11-29 at 14 22 02

@Divide-By-0
Copy link
Member

Divide-By-0 commented Dec 21, 2023

@isidroamv great! I will merge. We can greatly improve these tests, I added it to #9. For starters, we shuold rename the circuit tests to contract tests since that what they currently are!

unit tests only have this right now:

PASS tests/e2e-ui.test.ts (11.786 s)
  App.js
    ✓ should allow email and eth addr to be entered into inputs (1217 ms)
    ✓ should start with an enabled prove button and status should be 'not-started' (1217 ms)

These only test trivial UI functionality; they don't actually verify the download functionality or witness generation works -- can we add tests for those?

@Divide-By-0 Divide-By-0 merged commit f8ad551 into main Dec 21, 2023
3 checks passed
@saleel saleel deleted the git-actions branch January 24, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants