develop -> main #172
develop -> main #172
Conversation
This reverts commit c708a2d.
pass LOAD_URL as param, and put LOAD_URL into .env
…into isidroamv-refactor-docs
Refactoring and cleanup in helpers
| @@ -2,6 +2,7 @@ | |||
| # | |||
| # | |||
|
|
|||
| dist | |||
There was a problem hiding this comment.
Wait I think we actually do want to push some dist for ts so that you can get non relative js imports. @Metachaser24 added this I believe
There was a problem hiding this comment.
@isidroamv made those changes in the end
There was a problem hiding this comment.
dist was removed the repo - yarn build will run before yarn publish and dist is set to be part of npm package.
| #!/usr/bin/env sh | ||
| . "$(dirname -- "$0")/_/husky.sh" | ||
|
|
||
| echo " * Please remember to run 'yarn run test:e2e-zkp' before opening a PR. *\n * note: The dev server should be running on port 3000 for the e2e tests to pass. *\n" |
There was a problem hiding this comment.
This is a nice hook to have, why delete? We can add linters etc
There was a problem hiding this comment.
Doing full e2e-zkp before each push would be quite annoying. We have it as part of CI anyway.
We don't have prettier set up right now - I will create an issue for that.
| @@ -1,404 +0,0 @@ | |||
| Delivered-To: [email protected] | |||
There was a problem hiding this comment.
Wait where did this file go, it's nice to have around
There was a problem hiding this comment.
This is test email for twitter - moved it to twitter repo
| @@ -1,19 +0,0 @@ | |||
| { | |||
| "name": "@zk-email/e2e-lambdatest", | |||
There was a problem hiding this comment.
Wait so where did this package go
There was a problem hiding this comment.
Moved to twitter-repo. They are twitter specific tests.
|
We should remove the now defunct
|
Removed the webhook |
Description
This PR includes changes from #163, #156, #144
Type of Change
Please delete options that are not relevant.
Checklist: