Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fix to handle circuit test timeout #219

Merged
merged 5 commits into from
Oct 1, 2024

Conversation

saleel
Copy link
Member

@saleel saleel commented Sep 8, 2024

Description

  • Minor fix to handle circuit test timeout
  • Rename split-bytes-to-words test file to match file naming case convention

This PR is based to revert/regex-update but will automatically change to main once #218 is merged.

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • I have discussed with the team prior to submitting this PR
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes

@Divide-By-0
Copy link
Member

Hmmm id prefer to make tests smaller or increase parallelism to increasing test time, or else dev iteration time slows down due to slower tests.

@saleel
Copy link
Member Author

saleel commented Sep 27, 2024

Hmmm id prefer to make tests smaller or increase parallelism to increasing test time, or else dev iteration time slows down due to slower tests.

Yea, but its less likely circom compilation and tests will run in default timeout. We already have smaller circuits for testing individual templates. This was necessary in my machine to finish the tests.

@Divide-By-0 Divide-By-0 merged commit 0b8517f into revert/regex-update Oct 1, 2024
5 checks passed
@saleel saleel deleted the fix/circuit-test branch October 1, 2024 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants