Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update of UserOverrideableDKIMRegistry #233

Merged
merged 10 commits into from
Oct 25, 2024
Merged

Conversation

SoraSuegami
Copy link
Collaborator

@SoraSuegami SoraSuegami commented Oct 20, 2024

Description

The current implementation of UserOverrideableDKIMRegistry only supports pessimistic key updates; i.e., each user's approval is always required to enable a new public key set by the main authorizer.
This causes liveness issues when the user loses access to their account.
However, a naive implementation for optimistic key updates, which enables a new public key set by the main authorizer without the user's approval immediately, has a safety issue when the main authority is invalid.
To make it possible to balance this tradeoff, this PR introduces a time delay until the public key set by the main authorizer is enabled without the user's approval.
Such a public key is enabled 1) after the time delay passes or 2) when the user approves the public key before the time delay passes.
Therefore, the greater the delay becomes, the closer it approaches a pessimistic update, while the opposite brings it closer to an optimistic update.

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • I have discussed with the team prior to submitting this PR
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes

Copy link
Contributor

@wshino wshino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about upgrading solc_version to match one of the ether-email-auth?

@SoraSuegami SoraSuegami marked this pull request as ready for review October 21, 2024 12:25
Copy link

socket-security bot commented Oct 21, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher

View full report↗︎

@SoraSuegami SoraSuegami merged commit 3b3c808 into main Oct 25, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants