Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduce bpr (parallel) Bucket point redution algorithm in gpu.
New Utility Functions:
bpr.metal
, with 2 kernels:bpr_stage_1
andbpr_stage_2
.Refactoring and Enhancements:
jacobian_add_2007_bl
) to handle special cases where one of the points is zero or both points are equal (mopro-msm/src/msm/metal_msm/shader/curve/jacobian.metal
). [1] [2]jacobian_dbl_2009_l
function to the top of the file and added it to thejacobian_add_2007_bl
function to handle doubling when points are equal (mopro-msm/src/msm/metal_msm/shader/curve/jacobian.metal
). [1] [2]New Functions:
jacobian_scalar_mul
function to perform scalar multiplication on Jacobian points (mopro-msm/src/msm/metal_msm/shader/curve/jacobian.metal
).run
for scalar multiplication injacobian_scalar_mul.metal
(mopro-msm/src/msm/metal_msm/shader/curve/jacobian_scalar_mul.metal
).Tests:
bpr_stage_1
test in rust side (mopro-msm/src/msm/metal_msm/shader/cuzk/bpr.rs
)bpr_stage_2
test in rust side.TODOs
bpr_stage_1
is correct.bpr_stage_2
is correct.