feat(cli): create ios/android template #245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying mopro with
|
| Latest commit: |
e309763
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://cd3cf56b.mopro.pages.dev |
| Branch Preview URL: | https://cli-create.mopro.pages.dev |
vivianjeng
changed the title
cli/src/build.rs
Outdated
| @@ -1,4 +1,7 @@ | |||
| use crate::style::{self, blue_bold, print_green_bold}; | |||
| use crate::{ | |||
There was a problem hiding this comment.
In my rust files I put 1 import per line to prevent merge conflicts. I order the imports as std first, external crates second, and local modules third. A good example is here
There was a problem hiding this comment.
In my rust files I put 1 import per line to prevent merge conflicts. I order the imports as
stdfirst, external crates second, and local modules third. A good example is here
I follow this rule as well. we could consider enabling group_imports in rustfmt to help avoid conflicts and keep lines shorter.
It’s an unstable feature but might be worth trying.
There was a problem hiding this comment.
@sifnoc Yes currently I don't follow the order to import packages
We can do that in another PR 👍🏻
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#234