CLI can select target arch #270
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vivianjeng
reviewed
Dec 13, 2024
Comment on lines
3
to
+22
| fn main() { | ||
| let ios_archs: Vec<String> = if let Ok(ios_archs) = std::env::var("IOS_ARCHS") { | ||
| ios_archs.split(',').map(|arch| arch.to_string()).collect() | ||
| } else { | ||
| // Default case: select all supported architectures if none are provided | ||
| IOS_ARCHS.iter().map(|&arch| arch.to_string()).collect() | ||
| }; | ||
|
|
||
| // Check 'IOS_ARCH' input validation | ||
| for arch in &ios_archs { | ||
| assert!( | ||
| IOS_ARCHS.contains(&arch.as_str()), | ||
| "Unsupported architecture: {}", | ||
| arch | ||
| ); | ||
| } | ||
|
|
||
| // A simple wrapper around a build command provided by mopro. | ||
| // In the future this will likely be published in the mopro crate itself. | ||
| mopro_ffi::app_config::ios::build(); | ||
| mopro_ffi::app_config::ios::build(&ios_archs); |
There was a problem hiding this comment.
I think passing archs as inputs doesn't make much sense to me
and I think letting users maintaining the line 4-18 is too much work
(and we have to maintain double files in template and test-e2e, and also documentation)
if it is in env, it can just let mopro_ffi::app_config::ios::build() to read the env and handle the error assertions?
like the debug/release mode, it is also handled by mopro_ffi::app_config::ios::build()
|
This PR will be replace another new PR with https://github.com/zkmopro/mopro/tree/selectable_target_arch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mopro-ffi:app_config::ios::buildandmopro-ffi:app_config::android::buildnow requiretarget_archas an input instead of being hardcoded value inside the function.cli/src/template/init/bin/*andtest-e2e/src/bin/*read thetarget_archvalue from the environment variable. If no value is provided, all available architectures are selected by default.mopro-fficrate in the cli for only reading*_ARCHSvariables. It's too heavy to compile for simple.