Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ci #39

Merged
merged 2 commits into from
Nov 30, 2023
Merged

Fix ci #39

merged 2 commits into from
Nov 30, 2023

Conversation

vivianjeng
Copy link
Collaborator

  • comment out rsa, anon-aadhaar tests
  • download arkzkey from server (the server url could be changed)
  • fix readme in ark-zkey package
  • add lint test

@vivianjeng vivianjeng requested a review from oskarth November 24, 2023 11:14
Copy link
Collaborator

@oskarth oskarth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Overall looks good, some questions above though

mopro-ios/MoproKit/Example/MoproKit/ViewController.swift Outdated Show resolved Hide resolved
scripts/prepare_ci.sh Outdated Show resolved Hide resolved
@vivianjeng vivianjeng requested a review from oskarth November 29, 2023 15:48
@oskarth oskarth merged commit 58299bd into zkmopro:main Nov 30, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants