-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(chore): Add latest version of AA circuits #66
Conversation
scripts/update_bindings.sh
Outdated
@@ -138,12 +138,12 @@ cp ${TARGET_DIR}/libmopro_ffi.a ${MOPROKIT_DIR}/Libs/ | |||
# TODO: Hardcoded to rsa for now | |||
if [[ "$USE_DYLIB" == true ]]; then | |||
print_action "Copying dynamic library asset (rsa)..." | |||
cp ${PROJECT_DIR}/mopro-core/target/${ARCHITECTURE}/${LIB_DIR}/rsa.dylib ${TARGET_DIR}/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just pushed this 0e824f5
So we can add anonAadhaar
as an argument and write this in anonAadhaar/README.md for how to run
@@ -594,7 +599,7 @@ | |||
baseConfigurationReference = 5DAF212A114DFA0C9F4282B2 /* Pods-MoproKit_Tests.debug.xcconfig */; | |||
buildSettings = { | |||
BUNDLE_LOADER = "$(BUILT_PRODUCTS_DIR)/MoproKit_Example.app/MoproKit_Example"; | |||
DEVELOPMENT_TEAM = ""; | |||
DEVELOPMENT_TEAM = 7BMWCJP4MA; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here too
mopro-core/build.rs
Outdated
@@ -79,8 +79,10 @@ fn build_dylib(wasm_path: String, dylib_name: String) -> Result<()> { | |||
|
|||
fn main() -> Result<()> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is very messy... I'm working on making this easier to work with. Will update once fixed, then we can make this easier to merge
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok let me know, how I should resolve once done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See https://github.com/oskarth/mopro/pull/67/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5R34 for what to do
I suggest adding an anon-aadhaar-config.toml
to this PR
Tested in Xcode Simulator and getting: This is due to it calling I think for simplicity we can start without the dylib, comment out that dylib init block in iOS and use vanilla wasm (like other examples)? IIRC the main impact is that you can't disconnect cable, but perf should be basically the same. WDYT? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Let me try
Ah ti seems like CI is failing
and
(also Android but think this is unrelated to PR) |
(Also on simulator):
Proof verification doesn't seem to work, is this to be expected with dummy data or so? |
Regarding the first issue with JSON loading, it's weird because these tests are marked as being ignored by the CI, so this piece of code shouldn't be triggered by the CI workflow. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please run cargo fmt --all
in mopro-core
This adds the latest version of the AA protocol circuits.
zkey file: 1.05GB
Number of constraints: 1,767,153
mopro-core