Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: toml config #68

Merged
merged 2 commits into from
Feb 1, 2024
Merged

Fix: toml config #68

merged 2 commits into from
Feb 1, 2024

Conversation

vivianjeng
Copy link
Collaborator

  • add target check for android devices
  • fix ci: the device type is x86_64

Copy link
Collaborator

@oskarth oskarth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Would you mind rebasing before merging?

@@ -93,7 +93,7 @@ print_action "[core/circom] Generating arkzkey for rsa..."
print_action "[ffi] Adding support for target architectures..."
cd ${PROJECT_DIR}/mopro-ffi

for target in x86_64-apple-ios aarch64-apple-ios aarch64-apple-ios-sim; do
for target in x86_64-apple-ios aarch64-apple-ios aarch64-apple-ios-sim aarch64-linux-android armv7-linux-androideabi i686-linux-android x86_64-linux-android; do
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this and prepare_ci line only diff?

@vivianjeng vivianjeng merged commit df984fb into main Feb 1, 2024
4 of 6 checks passed
@vivianjeng vivianjeng deleted the fix/toml-config branch February 1, 2024 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants