Skip to content

Commit

Permalink
New match type: inGameStrID (#960)
Browse files Browse the repository at this point in the history
  • Loading branch information
beer-psi authored Oct 11, 2023
1 parent 7f5c56e commit d9e0172
Show file tree
Hide file tree
Showing 7 changed files with 1,146 additions and 1,099 deletions.
4 changes: 2 additions & 2 deletions common/src/config/game-support/arcaea.ts
Original file line number Diff line number Diff line change
Expand Up @@ -125,12 +125,12 @@ export const ARCAEA_TOUCH_CONF = {
},

chartData: z.strictObject({
inGameID: z.string(),
inGameStrID: z.string(),
notecount: zodNonNegativeInt,
}),

preferences: z.strictObject({}),
scoreMeta: z.strictObject({}),

supportedMatchTypes: ["inGameID", "songTitle", "tachiSongID"],
supportedMatchTypes: ["inGameStrID", "songTitle", "tachiSongID"],
} as const satisfies INTERNAL_GAME_PT_CONFIG;
2 changes: 1 addition & 1 deletion common/src/config/game-support/maimai.ts
Original file line number Diff line number Diff line change
Expand Up @@ -164,5 +164,5 @@ export const MAIMAI_SINGLE_CONF = {
preferences: z.strictObject({}),
scoreMeta: z.strictObject({}),

supportedMatchTypes: ["songTitle", "tachiSongID", "inGameID"],
supportedMatchTypes: ["songTitle", "tachiSongID", "inGameID", "inGameStrID"],
} as const satisfies INTERNAL_GAME_PT_CONFIG;
1 change: 1 addition & 0 deletions common/src/lib/schemas.ts
Original file line number Diff line number Diff line change
Expand Up @@ -842,6 +842,7 @@ const PR_BATCH_MANUAL_SCORE = (game: Game, playtype: Playtype): PrudenceSchema =
"itgChartHash",
"sdvxInGameID",
"inGameID",
"inGameStrID",
"uscChartHash",
"popnChartHash"
),
Expand Down
7 changes: 6 additions & 1 deletion common/src/types/batch-manual.ts
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,12 @@ import type { AllFieldsNullableOptional } from "./utils";
type MatchTypesNoDifficulty = "bmsChartHash" | "itgChartHash" | "popnChartHash" | "uscChartHash";

// These MatchTypes need `difficulty` set in the batch manual.
type MatchTypesWithDifficulty = "inGameID" | "sdvxInGameID" | "songTitle" | "tachiSongID";
type MatchTypesWithDifficulty =
| "inGameID"
| "inGameStrID"
| "sdvxInGameID"
| "songTitle"
| "tachiSongID";

export type MatchTypes = MatchTypesNoDifficulty | MatchTypesWithDifficulty;

Expand Down
Loading

0 comments on commit d9e0172

Please sign in to comment.