feat: stricter seeds, more validation, etc. #1059

zkrising · 2024-05-03T16:30:13Z

Some surprising errors slipped into the seeds and weren't caught by our existing tests. I've added infrastructure to add custom checks per-game so seeds maintainers can more accurately prevent errors from slipping into the seeds.

CC @GRIM657, @MinaAngura, @beerpiss, @j1nxie, @cg505, and anyone else who is contributing to seeds

Please add some appropriate validation tests to this file, and fix all of the issues highlighted.

IIDX:

[ERR] charts-iidx.json | ON - Get on Beat (55) - DP NORMAL (8cbc49c65e02a4c72eac746ae300cdfc24f84612) | Error: versions | Versions array should not be empty as this game uses versions..
[ERR] charts-iidx.json | ON - Get on Beat (55) - SP NORMAL (5fe8688fedae2bb08e0f8a82ce4101500610f248) | Error: versions | Versions array should not be empty as this game uses versions..
[ERR] charts-iidx.json | Hirofumi Asamoto (ram jam world) - Junglist King (56) - DP NORMAL (cae0f62390dcbafa71e68197e342fa1bea73802d) | Error: versions | Versions array should not be empty as this game uses versions..
[ERR] charts-iidx.json | Hirofumi Asamoto (ram jam world) - Junglist King (56) - SP NORMAL (5e2472c46f86737dd0cb157720a26ed29d632409) | Error: versions | Versions array should not be empty as this game uses versions..
[ERR] charts-iidx.json | STONE BROS. - LET THE BEAT HIT EM! BASS MIX (58) - DP NORMAL (7bae78d0ae7ec0c4b04d8eee5c8398ed48f7ed3f) | Error: versions | Versions array should not be empty as this game uses versions..
[ERR] charts-iidx.json | STONE BROS. - LET THE BEAT HIT EM! BASS MIX (58) - SP NORMAL (c055985c74a040cf6834ebee693b1c6f56e32203) | Error: versions | Versions array should not be empty as this game uses versions..
[ERR] charts-iidx.json | Sota Fujimori - Look To The Sky(cyber True Color) (590) - DP ANOTHER (eb6c16a73809c81f5fbee10d6b34b052aa257241) | Error: versions | Versions array should not be empty as this game uses versions..

WACCA:

[ERR] charts-wacca.json | 米津玄師 - ピースサイン (336) - Single EXPERT (4323466334bd4f80daf674ccb174fe8815f4d2be) | Error: versions | Versions array should not be empty as this game uses versions..
[ERR] charts-wacca.json | 米津玄師 - ピースサイン (336) - Single HARD (cf31db26bb5bc6a022a155641bb82adaff01d26f) | Error: versions | Versions array should not be empty as this game uses versions..
[ERR] charts-wacca.json | 米津玄師 - ピースサイン (336) - Single NORMAL (510613910d774deea3479b153e0593c3c81a2b2d) | Error: versions | Versions array should not be empty as this game uses versions..
[FAILED] charts-wacca. GOOD: 1181, BAD: 3(100.00%).

CHUNITHM:

[ERR] charts-chunithm.json | REDALiCE (HARDCORE TANO*C) - taboo tears you up (20) - Single ULTIMA (796298ba8d816b6aa2302312cdc7afb0f93c9e05) | Error: versions | Versions array should not be empty as this game uses versions..
[ERR] charts-chunithm.json | かいりきベア feat.GUMI・鏡音リン - イナイイナイ依存症 (2515) - Single ADVANCED (625ee526637ee5f341947131f56d04a82ff7e5ff) | Error: versions | Versions array should not be empty as this game uses versions..
[ERR] charts-chunithm.json | かいりきベア feat.GUMI・鏡音リン - イナイイナイ依存症 (2515) - Single BASIC (10fb288e7851bb5c4547e2d972eae77c720c54e2) | Error: versions | Versions array should not be empty as this game uses versions..
[ERR] charts-chunithm.json | かいりきベア feat.GUMI・鏡音リン - イナイイナイ依存症 (2515) - Single EXPERT (043db1dfe3277cd33d1e55c46769ca1c176ef7b9) | Error: versions | Versions array should not be empty as this game uses versions..
[ERR] charts-chunithm.json | かいりきベア feat.GUMI・鏡音リン - イナイイナイ依存症 (2515) - Single MASTER (c7fc6189fd5849b16cde08d061f655648e9693c2) | Error: versions | Versions array should not be empty as this game uses versions..
[ERR] charts-chunithm.json | かいりきベア - バグ (2517) - Single ADVANCED (8ae8a041f9bf357a17ef81890ee27aaa59c783c8) | Error: versions | Versions array should not be empty as this game uses versions..
[ERR] charts-chunithm.json | かいりきベア - バグ (2517) - Single BASIC (dbff0725a0ed36c0a7b379128c58e8e5acc5d864) | Error: versions | Versions array should not be empty as this game uses versions..
[ERR] charts-chunithm.json | かいりきベア - バグ (2517) - Single EXPERT (f286574efef01821d5f5b8e64a8e659331f1d0f7) | Error: versions | Versions array should not be empty as this game uses versions..
[ERR] charts-chunithm.json | かいりきベア - バグ (2517) - Single MASTER (6f04ceffca74a67bd7cb81d31b4bd97a85f5baac) | Error: versions | Versions array should not be empty as this game uses versions..
[ERR] charts-chunithm.json | 削除 - D-Birth (2536) - Single ADVANCED (3710f447c41e3e75e7550c5607c0cc19a0742be9) | Error: versions | Versions array should not be empty as this game uses versions..
[ERR] charts-chunithm.json | 削除 - D-Birth (2536) - Single BASIC (8270d1ffe90dcc3c55e56091b722cdfea8c9f903) | Error: versions | Versions array should not be empty as this game uses versions..
[ERR] charts-chunithm.json | 削除 - D-Birth (2536) - Single EXPERT (32ce3d01e65d1db36fc44ccdde4976157b91d4d8) | Error: versions | Versions array should not be empty as this game uses versions..
[ERR] charts-chunithm.json | 削除 - D-Birth (2536) - Single MASTER (6da4890f80209f5a45a1deff8c02e95f77256e1b) | Error: versions | Versions array should not be empty as this game uses versions..
[ERR] charts-chunithm.json | Blacklolita - GIGA BLAST (2537) - Single ADVANCED (d86a3f0309ab1e42cd2aca4566d72696df75d3f8) | Error: versions | Versions array should not be empty as this game uses versions..
[ERR] charts-chunithm.json | Blacklolita - GIGA BLAST (2537) - Single BASIC (72dc2576d5e2c35c09cc0ea2952c53f24d38add2) | Error: versions | Versions array should not be empty as this game uses versions..
[ERR] charts-chunithm.json | Blacklolita - GIGA BLAST (2537) - Single EXPERT (e15c99272bb53d60a9845390c15ef6c6f4f570ad) | Error: versions | Versions array should not be empty as this game uses versions..
[ERR] charts-chunithm.json | Blacklolita - GIGA BLAST (2537) - Single MASTER (5ad8ac2af662c744bf0a90c5ecd8047650a6d128) | Error: versions | Versions array should not be empty as this game uses versions..
[ERR] charts-chunithm.json | xi - Longinus (2538) - Single ADVANCED (742d85cc7df12d58b1dc33ae9ca3ef6a167346c6) | Error: versions | Versions array should not be empty as this game uses versions..
[ERR] charts-chunithm.json | xi - Longinus (2538) - Single BASIC (9eff7b43a105fc7273e2e29164401734c28ff39b) | Error: versions | Versions array should not be empty as this game uses versions..
[ERR] charts-chunithm.json | xi - Longinus (2538) - Single EXPERT (53410273c55cbe8c79e2471999cc70b12b1088c8) | Error: versions | Versions array should not be empty as this game uses versions..
[ERR] charts-chunithm.json | xi - Longinus (2538) - Single MASTER (52a71f58d22fd3d900f6722ac9019d8c53a8d315) | Error: versions | Versions array should not be empty as this game uses versions..
[ERR] charts-chunithm.json | cosMo@暴走P - Ωκεανος (2539) - Single ADVANCED (53833c30ef7d7758820a4726dd373cac2de1aeb7) | Error: versions | Versions array should not be empty as this game uses versions..
[ERR] charts-chunithm.json | cosMo@暴走P - Ωκεανος (2539) - Single BASIC (626fc55a1b92837e1a5e0d04cd500c14cb86a5a6) | Error: versions | Versions array should not be empty as this game uses versions..
[ERR] charts-chunithm.json | cosMo@暴走P - Ωκεανος (2539) - Single EXPERT (e23388a5d3f54351e59877e1026c3bf57d6613dc) | Error: versions | Versions array should not be empty as this game uses versions..
[ERR] charts-chunithm.json | cosMo@暴走P - Ωκεανος (2539) - Single MASTER (7830459941c5525dd1a0e3ff59b89b463f57eb74) | Error: versions | Versions array should not be empty as this game uses versions..
[ERR] charts-chunithm.json | Hommarju - Love's Theme of BADASS ～バッド・アス 愛のテーマ～ (2540) - Single ADVANCED (33fa2e51b1d3089588132b220eab561f7f61d73d) | Error: versions | Versions array should not be empty as this game uses versions..
[ERR] charts-chunithm.json | Hommarju - Love's Theme of BADASS ～バッド・アス 愛のテーマ～ (2540) - Single BASIC (4f0650352842397e11da7bf0dc490d6407547265) | Error: versions | Versions array should not be empty as this game uses versions..
[ERR] charts-chunithm.json | Hommarju - Love's Theme of BADASS ～バッド・アス 愛のテーマ～ (2540) - Single EXPERT (f0b3a80affa0a81e5f17bfb61259810b1494d9eb) | Error: versions | Versions array should not be empty as this game uses versions..
[ERR] charts-chunithm.json | Hommarju - Love's Theme of BADASS ～バッド・アス 愛のテーマ～ (2540) - Single MASTER (15812862f29e78321a90cccbba5821cefa6453e8) | Error: versions | Versions array should not be empty as this game uses versions..
[ERR] charts-chunithm.json | 天王洲 なずな(CV:山本 彩乃) - ラビットランド・メッセンジャー (2550) - Single ADVANCED (01e7e52d4ed6f20c7a7dbb6ec77e7b5805d5c39a) | Error: versions | Versions array should not be empty as this game uses versions..
[ERR] charts-chunithm.json | 天王洲 なずな(CV:山本 彩乃) - ラビットランド・メッセンジャー (2550) - Single BASIC (df60b41ca19a4869dfae326f29583db9b96fb164) | Error: versions | Versions array should not be empty as this game uses versions..
[ERR] charts-chunithm.json | 天王洲 なずな(CV:山本 彩乃) - ラビットランド・メッセンジャー (2550) - Single EXPERT (df2a0f0d141fb3e5f78fcd7128a27a7c60db17de) | Error: versions | Versions array should not be empty as this game uses versions..
[ERR] charts-chunithm.json | 天王洲 なずな(CV:山本 彩乃) - ラビットランド・メッセンジャー (2550) - Single MASTER (e045d03f59599ed98cd96288c8fe258e8bccbf47) | Error: versions | Versions array should not be empty as this game uses versions..
[ERR] charts-chunithm.json | siromaru - Adverse Gaff (2557) - Single ADVANCED (95e804cdb1cb58ff9b56145dd776ba679962ff63) | Error: versions | Versions array should not be empty as this game uses versions..
[ERR] charts-chunithm.json | siromaru - Adverse Gaff (2557) - Single BASIC (feb8de0016f802c4764e2f9968cb99f28cfde9f4) | Error: versions | Versions array should not be empty as this game uses versions..
[ERR] charts-chunithm.json | siromaru - Adverse Gaff (2557) - Single EXPERT (99787f937c5d64a8201d5115314a29e3ff1d8c44) | Error: versions | Versions array should not be empty as this game uses versions..
[ERR] charts-chunithm.json | siromaru - Adverse Gaff (2557) - Single MASTER (7b783c67b6bf73168f8ee04a27117147128aef32) | Error: versions | Versions array should not be empty as this game uses versions..
[FAILED] charts-chunithm. GOOD: 6143, BAD: 37(100.00%).

Please fix these issues as soon as possible and add more validators as you see fit. Thanks.

zkrising · 2024-05-03T16:35:15Z

n.b. i know that you guys can't commit directly to this PR so please make a branch from this branch and then PR into it.

* Removed nonexistent charts * Removed duplicate Version entries for 28-2dxtra

This was referenced May 4, 2024

[iidx] Fixed various issues re: Versions tags #1060

Closed

[iidx] Fixed various issues re: Versions tags #1061

Merged

zkrising force-pushed the zkldi/stricter-seeds branch from de9a567 to 10fda7c Compare May 9, 2024 19:54

zkrising and others added 5 commits May 10, 2024 12:02

feat: stricter seeds, more validation, etc.

d48dfb6

fix: count

a832111

[iidx] Fixed various issues re: Versions tags (#1061)

47f8dac

* Removed nonexistent charts * Removed duplicate Version entries for 28-2dxtra

feat: mandate uniq versions

8c5774e

fix: i hate this

5558327

zkrising force-pushed the zkldi/stricter-seeds branch from f58715a to 5558327 Compare May 10, 2024 11:02

zkrising added 2 commits May 10, 2024 12:04

feat: whatever put this back in the game

abe756d

fix: make test pass

ace5612

zkrising merged commit 8fca6ef into main May 10, 2024
8 checks passed

zkrising deleted the zkldi/stricter-seeds branch May 10, 2024 11:13

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: stricter seeds, more validation, etc. #1059

feat: stricter seeds, more validation, etc. #1059

zkrising commented May 3, 2024

zkrising commented May 3, 2024

feat: stricter seeds, more validation, etc. #1059

feat: stricter seeds, more validation, etc. #1059

Conversation

zkrising commented May 3, 2024

IIDX:

WACCA:

CHUNITHM:

zkrising commented May 3, 2024