Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add inGameID matching support for maimai DX and support nullable inGameIDs in general #1114

Merged
merged 12 commits into from
Jul 4, 2024
Merged

Add inGameID matching support for maimai DX and support nullable inGameIDs in general #1114

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
5567109
warn about null/missing inGameIDs
beer-psi Jun 17, 2024
95dce30
add support for inGameID matching in maimai DX
beer-psi Jun 17, 2024
1df8f99
add indexes for maimai classic charts
beer-psi Jun 17, 2024
1e258e0
fix variable ordering
beer-psi Jun 17, 2024
3b3236c
Make custom tests work so we can avoid some footguns
beer-psi Jun 17, 2024
8560cd1
linting
beer-psi Jun 17, 2024
3b96b0c
add inGameID to maimai DX test data
beer-psi Jun 17, 2024
3f1ce1e
eslint why u no work
beer-psi Jun 17, 2024
bd5322b
more readable tests
beer-psi Jun 18, 2024
4d42434
clean up scripts
beer-psi Jun 18, 2024
6ef7ce3
[maimaidx] Splice 1
beer-psi Jun 18, 2024
b517ef5
Rising in the Sun SPH's levelNum should be 8
beer-psi Jun 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions common/src/config/game-support/maimai-dx.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,10 +211,12 @@ export const MAIMAI_DX_SINGLE_CONF = {
buddiesplus: "BUDDiES PLUS",
},

chartData: z.strictObject({}),
chartData: z.strictObject({
inGameID: z.number().int().nonnegative().nullable(),
}),

preferences: z.strictObject({}),
scoreMeta: z.strictObject({}),

supportedMatchTypes: ["songTitle", "tachiSongID"],
supportedMatchTypes: ["songTitle", "tachiSongID", "inGameID"],
} as const satisfies INTERNAL_GAME_PT_CONFIG;
4 changes: 2 additions & 2 deletions database-seeds/collections/charts-iidx.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162258,7 +162258,7 @@
"difficulty": "HYPER",
"isPrimary": true,
"level": "8",
"levelNum": 9,
"levelNum": 8,
"playtype": "SP",
"songID": 761,
"versions": [
Expand Down Expand Up @@ -1406404,4 +1406404,4 @@
"30-2dxtra"
]
}
]
]
Loading
Loading