Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add myt maimai dx import support #1143

Merged
merged 6 commits into from
Aug 9, 2024
Merged

Conversation

albshin
Copy link
Contributor

@albshin albshin commented Aug 8, 2024

Adds MYT maimai DX support

There's currently a bug where UTAGE charts are returning UNSPECIFIED from the backend, not that it matters since we ignore UNSPECIFIED difficulties but please do not merge until this is fixed.

All other errors are due to KT MaiMai DX seeds missing omnimix songs.

image

@albshin albshin marked this pull request as ready for review August 9, 2024 06:27
@albshin
Copy link
Contributor Author

albshin commented Aug 9, 2024

Utage bug is fixed

@@ -40,7 +40,7 @@ const parsedScore: MytChunithmScore = {
},
};

t.test("#ConvertAPIMytOngeki", (t) => {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

heh

@zkrising
Copy link
Owner

zkrising commented Aug 9, 2024

Looks good to me. Thank you for yr work!

@zkrising zkrising merged commit 17a95f1 into zkrising:main Aug 9, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants