Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: songTitle+artist match #1154

Merged
merged 4 commits into from
Aug 23, 2024
Merged

Conversation

nyairobi
Copy link
Contributor

This branch adds an optional artist field to the batch-manual spec, which gets taken into account if matching by songTitle. Consider it a specialized identifier2. I think this is the path of least resistance towards songTitle not sucking.

Not benchmarked because I wouldn't know how.

Tested with the import below.
There are 3 Singularities and 1 World Vanquisher in the game.
Everything is imported correctly except the 30 score, as expected, because it doesn't have an artist field.

{
    "meta": {
        "game": "ongeki",
        "playtype": "Single",
        "service": "Test"
    },
    "scores": [
        {
            "score": 10,
            "noteLamp": "LOSS",
            "bellLamp": "NONE",
            "matchType": "songTitle",
            "identifier": "Singularity",
            "difficulty": "MASTER",
            "artist": "ETIA.「Arcaea」"
        },
        {
            "score": 20,
            "noteLamp": "LOSS",
            "bellLamp": "NONE",
            "matchType": "songTitle",
            "identifier": "Singularity",
            "difficulty": "MASTER",
            "artist": "technoplanet"
        },
        {
            "score": 30,
            "noteLamp": "LOSS",
            "bellLamp": "NONE",
            "matchType": "songTitle",
            "identifier": "Singularity",
            "difficulty": "MASTER"
        },
        {
            "score": 40,
            "noteLamp": "LOSS",
            "bellLamp": "NONE",
            "matchType": "songTitle",
            "identifier": "World Vanquisher",
            "difficulty": "MASTER"
        },
        {
            "score": 50,
            "noteLamp": "LOSS",
            "bellLamp": "NONE",
            "matchType": "songTitle",
            "identifier": "World Vanquisher",
            "artist": "void (Mournfinale)",
            "difficulty": "MASTER"
        }
    ]
}

@zkrising
Copy link
Owner

This feels ugly but it's definitely the path of least resistance. Thank you for sorting this out.

@zkrising zkrising merged commit b4e863c into zkrising:main Aug 23, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants