Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support exScore, fast, slow, maxCombo as optional metrics for DDR #1163

Merged
merged 4 commits into from
Sep 23, 2024
Merged

feat: support exScore, fast, slow, maxCombo as optional metrics for DDR #1163

merged 4 commits into from
Sep 23, 2024

Conversation

Gyoo
Copy link
Contributor

@Gyoo Gyoo commented Aug 24, 2024

Add support for several optional metrics for DDR :

  • Fast/Slow/MaxCombo
  • exScore, based on SDVX. Also available as a secondary score and session alg

zkrising
zkrising requested changes Aug 27, 2024
View reviewed changes
common/src/config/game-support/ddr.ts Outdated Show resolved Hide resolved
server/src/game-implementations/games/ddr.ts Outdated Show resolved Hide resolved
server/src/game-implementations/games/ddr.ts Outdated Show resolved Hide resolved
server/src/game-implementations/games/ddr.ts Show resolved Hide resolved
@Gyoo Gyoo requested a review from zkrising August 29, 2024 10:53
@zkrising zkrising merged commit ba4d924 into zkrising:main Sep 23, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zkrising zkrising Awaiting requested review from zkrising

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Gyoo @zkrising